Internet: Show device enabling and scanning states

chrome/browser/resources/settings/internet_page/network_summary.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Polymer element for displaying a summary of network states
  * by type: Ethernet, WiFi, Cellular, WiMAX, and VPN.
  */
 
 /** @typedef {chrome.networkingPrivate.DeviceStateProperties} */
@@ skipping 258 matching lines @@
    */
   updateNetworkStates_: function(networkStates, opt_deviceStates) {
     var newDeviceStates;
     if (opt_deviceStates) {
       newDeviceStates = /** @type {!DeviceStateObject} */ ({});
       for (var i = 0; i < opt_deviceStates.length; ++i) {
         var state = opt_deviceStates[i];
         newDeviceStates[state.Type] = state;
       }
     } else {
-      newDeviceStates = this.deviceStates;
+      newDeviceStates = Object.assign({}, this.deviceStates);

[michaelpg, 2017/04/17 20:33:27]

This is subtle, since the assignment to |this.deviceStates| is ~60 lines down.
Would it be worthwhile to factor out some helper methods for setting up
newDeviceStates, newNetworkStateLists, and newActiveNetworkStates from the
blocks below?

[stevenjb, 2017/04/17 20:41:31]

I actually have a CL that cleans this up some. It doesn't really help with
efficiency (which is what I was aiming for), but is probably worth committing as
a cleanup CL. Stay tuned :)

     }
 
     // Clear any current networks.
     var activeNetworkStatesByType =
         /** @type {!Map<string, !CrOnc.NetworkStateProperties>} */ (new Map);
 
     // Complete list of states by type.
     /** @type {!NetworkStateListObject} */ var newNetworkStateLists = {
       Ethernet: [],
       WiFi: [],
@@ skipping 47 matching lines @@
       newActiveNetworkStates.push(state);
       this.activeNetworkIds_.add(state.GUID);
     }
 
     this.deviceStates = newDeviceStates;
     this.networkStateLists_ = newNetworkStateLists;
     // Set activeNetworkStates last to rebuild the dom-repeat.
     this.activeNetworkStates_ = newActiveNetworkStates;
   },
 });