third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js - Issue 2819183002: [DevTools] Consolidate overlay-related functionality in Overlay domain

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js

Issue 2819183002: [DevTools] Consolidate overlay-related functionality in Overlay domain (Closed)

Patch Set: rebased Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/sdk/OverlayModel.js ('K') | « third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js ('k') | third_party/WebKit/Source/devtools/scripts/build/generate_protocol_externs.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js

index 8a1df75f6598ef0bcd79ff73991cd98069810e54..81d5220e53f474a5e1f75c9ccf647664306180f5 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js

@@ -154,7 +154,7 @@ Timeline.TimelineFlameChartView = class extends UI.VBox {

* @param {!Common.Event} commonEvent

_onEntryHighlighted(commonEvent) {

- SDK.DOMModel.hideDOMNodeHighlight();

+ SDK.OverlayModel.hideDOMNodeHighlight();

var entryIndex = /** @type {number} */ (commonEvent.data);

var event = this._mainDataProvider.eventByIndex(entryIndex);

if (!event)