Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Unified Diff: third_party/WebKit/Source/core/inspector/BUILD.gn

Issue 2819183002: [DevTools] Consolidate overlay-related functionality in Overlay domain (Closed)
Patch Set: rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/BUILD.gn
diff --git a/third_party/WebKit/Source/core/inspector/BUILD.gn b/third_party/WebKit/Source/core/inspector/BUILD.gn
index a7a18afa8fe8d8515a95a28dde5b9bf2c628a50d..f6d335191d2dc87d7ea5cacf8500b4386fa73262 100644
--- a/third_party/WebKit/Source/core/inspector/BUILD.gn
+++ b/third_party/WebKit/Source/core/inspector/BUILD.gn
@@ -148,12 +148,12 @@ inspector_protocol_generate("protocol_sources") {
"inspector/protocol/Memory.h",
"inspector/protocol/Network.cpp",
"inspector/protocol/Network.h",
+ "inspector/protocol/Overlay.cpp",
+ "inspector/protocol/Overlay.h",
"inspector/protocol/Page.cpp",
"inspector/protocol/Page.h",
"inspector/protocol/Protocol.cpp",
"inspector/protocol/Protocol.h",
- "inspector/protocol/Rendering.cpp",
- "inspector/protocol/Rendering.h",
"inspector/protocol/Runtime.h",
"inspector/protocol/Security.cpp",
"inspector/protocol/Security.h",
@@ -198,6 +198,7 @@ action("protocol_compatibility_check") {
inputs = [
"browser_protocol.json",
+ "protocol_compatibility_errors.json",
v8_inspector_js_protocol,
]
_stamp = "$blink_core_output_dir/inspector/browser_protocol.stamp"
@@ -208,6 +209,8 @@ action("protocol_compatibility_check") {
args = [
"--stamp",
rebase_path(_stamp, root_build_dir),
+ "--expected_errors",
+ rebase_path("protocol_compatibility_errors.json", root_build_dir),
rebase_path("browser_protocol.json", root_build_dir),
rebase_path(v8_inspector_js_protocol, root_build_dir),
]

Powered by Google App Engine
This is Rietveld 408576698