Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js

Issue 2819183002: [DevTools] Consolidate overlay-related functionality in Overlay domain (Closed)
Patch Set: rebased bad merge Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 22 matching lines...) Expand all
33 * @param {?Components.Linkifier} linkifier 33 * @param {?Components.Linkifier} linkifier
34 * @param {boolean} resultHighlightedAsDOM 34 * @param {boolean} resultHighlightedAsDOM
35 */ 35 */
36 constructor(linkifier, resultHighlightedAsDOM) { 36 constructor(linkifier, resultHighlightedAsDOM) {
37 this._linkifier = linkifier; 37 this._linkifier = linkifier;
38 this._resultHighlightedAsDOM = resultHighlightedAsDOM; 38 this._resultHighlightedAsDOM = resultHighlightedAsDOM;
39 } 39 }
40 40
41 dispose() { 41 dispose() {
42 if (this._resultHighlightedAsDOM) 42 if (this._resultHighlightedAsDOM)
43 SDK.DOMModel.hideDOMNodeHighlight(); 43 SDK.OverlayModel.hideDOMNodeHighlight();
44 if (this._linkifier) 44 if (this._linkifier)
45 this._linkifier.dispose(); 45 this._linkifier.dispose();
46 } 46 }
47 47
48 /** 48 /**
49 * @param {!SDK.RemoteObject} result 49 * @param {!SDK.RemoteObject} result
50 * @param {!UI.GlassPane} popover 50 * @param {!UI.GlassPane} popover
51 * @return {!Promise<?ObjectUI.ObjectPopoverHelper>} 51 * @return {!Promise<?ObjectUI.ObjectPopoverHelper>}
52 */ 52 */
53 static buildObjectPopover(result, popover) { 53 static buildObjectPopover(result, popover) {
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 false /* generatePreview */, 124 false /* generatePreview */,
125 didGetFunctionProperties.bind(null, result, popoverContentElement, v alueElement)); 125 didGetFunctionProperties.bind(null, result, popoverContentElement, v alueElement));
126 return promise; 126 return promise;
127 } 127 }
128 popover.contentElement.appendChild(popoverContentElement); 128 popover.contentElement.appendChild(popoverContentElement);
129 fulfill(new ObjectUI.ObjectPopoverHelper(null, false)); 129 fulfill(new ObjectUI.ObjectPopoverHelper(null, false));
130 } else { 130 } else {
131 var linkifier = null; 131 var linkifier = null;
132 var resultHighlightedAsDOM = false; 132 var resultHighlightedAsDOM = false;
133 if (result.subtype === 'node') { 133 if (result.subtype === 'node') {
134 SDK.DOMModel.highlightObjectAsDOMNode(result); 134 SDK.OverlayModel.highlightObjectAsDOMNode(result);
135 resultHighlightedAsDOM = true; 135 resultHighlightedAsDOM = true;
136 } 136 }
137 137
138 if (result.customPreview()) { 138 if (result.customPreview()) {
139 var customPreviewComponent = new ObjectUI.CustomPreviewComponent(result) ; 139 var customPreviewComponent = new ObjectUI.CustomPreviewComponent(result) ;
140 customPreviewComponent.expandIfPossible(); 140 customPreviewComponent.expandIfPossible();
141 popoverContentElement = customPreviewComponent.element; 141 popoverContentElement = customPreviewComponent.element;
142 } else { 142 } else {
143 popoverContentElement = createElementWithClass('div', 'object-popover-co ntent'); 143 popoverContentElement = createElementWithClass('div', 'object-popover-co ntent');
144 UI.appendStyle(popoverContentElement, 'object_ui/objectPopover.css'); 144 UI.appendStyle(popoverContentElement, 'object_ui/objectPopover.css');
145 var titleElement = popoverContentElement.createChild('div', 'monospace o bject-popover-title'); 145 var titleElement = popoverContentElement.createChild('div', 'monospace o bject-popover-title');
146 titleElement.createChild('span').textContent = description; 146 titleElement.createChild('span').textContent = description;
147 linkifier = new Components.Linkifier(); 147 linkifier = new Components.Linkifier();
148 var section = new ObjectUI.ObjectPropertiesSection(result, '', linkifier ); 148 var section = new ObjectUI.ObjectPropertiesSection(result, '', linkifier );
149 section.element.classList.add('object-popover-tree'); 149 section.element.classList.add('object-popover-tree');
150 section.titleLessMode(); 150 section.titleLessMode();
151 popoverContentElement.appendChild(section.element); 151 popoverContentElement.appendChild(section.element);
152 } 152 }
153 popover.setMaxContentSize(new UI.Size(300, 250)); 153 popover.setMaxContentSize(new UI.Size(300, 250));
154 popover.setSizeBehavior(UI.GlassPane.SizeBehavior.SetExactSize); 154 popover.setSizeBehavior(UI.GlassPane.SizeBehavior.SetExactSize);
155 popover.contentElement.appendChild(popoverContentElement); 155 popover.contentElement.appendChild(popoverContentElement);
156 fulfill(new ObjectUI.ObjectPopoverHelper(linkifier, resultHighlightedAsDOM )); 156 fulfill(new ObjectUI.ObjectPopoverHelper(linkifier, resultHighlightedAsDOM ));
157 } 157 }
158 return promise; 158 return promise;
159 } 159 }
160 }; 160 };
161 161
162 ObjectUI.ObjectPopoverHelper.MaxPopoverTextLength = 10000; 162 ObjectUI.ObjectPopoverHelper.MaxPopoverTextLength = 10000;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698