Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/elements/MetricsSidebarPane.js

Issue 2819183002: [DevTools] Consolidate overlay-related functionality in Overlay domain (Closed)
Patch Set: rebased bad merge Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2007 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 */ 117 */
118 _highlightDOMNode(showHighlight, mode, event) { 118 _highlightDOMNode(showHighlight, mode, event) {
119 event.consume(); 119 event.consume();
120 if (showHighlight && this.node()) { 120 if (showHighlight && this.node()) {
121 if (this._highlightMode === mode) 121 if (this._highlightMode === mode)
122 return; 122 return;
123 this._highlightMode = mode; 123 this._highlightMode = mode;
124 this.node().highlight(mode); 124 this.node().highlight(mode);
125 } else { 125 } else {
126 delete this._highlightMode; 126 delete this._highlightMode;
127 SDK.DOMModel.hideDOMNodeHighlight(); 127 SDK.OverlayModel.hideDOMNodeHighlight();
128 } 128 }
129 129
130 for (var i = 0; this._boxElements && i < this._boxElements.length; ++i) { 130 for (var i = 0; this._boxElements && i < this._boxElements.length; ++i) {
131 var element = this._boxElements[i]; 131 var element = this._boxElements[i];
132 if (!this.node() || mode === 'all' || element._name === mode) 132 if (!this.node() || mode === 'all' || element._name === mode)
133 element.style.backgroundColor = element._backgroundColor; 133 element.style.backgroundColor = element._backgroundColor;
134 else 134 else
135 element.style.backgroundColor = ''; 135 element.style.backgroundColor = '';
136 } 136 }
137 } 137 }
(...skipping 307 matching lines...) Expand 10 before | Expand all | Expand 10 after
445 if (commitEditor) 445 if (commitEditor)
446 this.update(); 446 this.update();
447 } 447 }
448 } 448 }
449 449
450 _editingCommitted(element, userInput, previousContent, context) { 450 _editingCommitted(element, userInput, previousContent, context) {
451 this.editingEnded(element, context); 451 this.editingEnded(element, context);
452 this._applyUserInput(element, userInput, previousContent, context, true); 452 this._applyUserInput(element, userInput, previousContent, context, true);
453 } 453 }
454 }; 454 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698