third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h - Issue 2819173002: [DMC #1.1] Refactor DocumentMarkerController::MoveMarkers()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

Issue 2819173002: [DMC #1.1] Refactor DocumentMarkerController::MoveMarkers() (Closed)

Patch Set: Refactor without adding a helper method yet Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

index 3f43df34c72d92e36f822f7c134ec1ea66a95af5..ff8f73a0f866a662fe2b9588697863bbf77b246f 100644

--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

@@ -149,6 +149,9 @@ class CORE_EXPORT DocumentMarkerController final

using MarkerLists =

HeapVector<Member<MarkerList>, DocumentMarker::kMarkerTypeIndexesCount>;

using MarkerMap = HeapHashMap<WeakMember<const Node>, Member<MarkerLists>>;

+ bool MoveMarkersToList(MarkerList* src_list,

Xiaocheng 2017/04/17 06:37:29 Please get rid of this.

+ int length,

+ MarkerList* dst_list);

bool PossiblyHasMarkers(DocumentMarker::MarkerTypes);

void RemoveMarkersFromList(MarkerMap::iterator, DocumentMarker::MarkerTypes);

void RemoveMarkers(TextIterator&, DocumentMarker::MarkerTypes);

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp » ('j') | no next file with comments »