Issue 2819056: Suppress a valgrind leak.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2819056: Suppress a valgrind leak. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by Nico

Modified:
4 years ago

Reviewers:
Lei Zhang, willchan no longer on Chromium, Paweł Hajdan Jr.

CC:
chromium-reviews, Timur Iskhodzhanov, stuartmorgan, pam+watch_chromium.org, Alexander Potapenko

Visibility:
Public.

Description

Suppress a valgrind leak. BUG=46886 TEST=net_tests goes green on memory waterfall. TBR=phajdan,willchan Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52994

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Trybot results:

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

This is the only bot I see failing in net right now: http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20(valgrind) and that's ...

4 years, 10 months ago (2010-07-20 04:12:54 UTC) #2

Nico

On Mon, Jul 19, 2010 at 9:12 PM, <thestig@chromium.org> wrote: > This is the only ...

4 years, 10 months ago (2010-07-20 14:45:05 UTC) #4

Nico

4 years, 10 months ago (2010-07-20 14:49:10 UTC) #5

On Tue, Jul 20, 2010 at 7:44 AM, Nico Weber <thakis@chromium.org> wrote:
> On Mon, Jul 19, 2010 at 9:12 PM,  <thestig@chromium.org> wrote:
>> This is the only bot I see failing in net right now:
>>
>>
http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20(valgrind)
>>
>> and that's not the right suppression for that bot.
>
> I grabbed the suppression from
>
http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20(valgrind...

I was about to say "And net is green now", but that's because of
http://codereview.chromium.org/3015010 :-P

Thanks!

Expand Messages | Collapse Messages