Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2819032: Revert 51312 - Disk cache: Switch the disk cache to use the cache_thread.... (Closed)

Created:
10 years, 5 months ago by rvargas (doing something else)
Modified:
9 years, 6 months ago
Reviewers:
Nicolas Sylvain
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, pam+watch_chromium.org, John Grabowski, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 51312 - Disk cache: Switch the disk cache to use the cache_thread. (tsan errors on the unit tests) Add an InFlightBackendIO class that handles posting of cacheoperations back and forth between the IO thread and the cachethread. BUG=26730 TEST=unit tests Review URL: http://codereview.chromium.org/2829008 TBR=nsylvain@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51325

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -1453 lines) Patch
MM net/disk_cache/backend_impl.h View 10 chunks +9 lines, -40 lines 0 comments Download
M net/disk_cache/backend_impl.cc View 17 chunks +87 lines, -228 lines 0 comments Download
MM net/disk_cache/backend_unittest.cc View 11 chunks +14 lines, -66 lines 0 comments Download
MM net/disk_cache/disk_cache_test_base.h View 4 chunks +1 line, -7 lines 0 comments Download
MM net/disk_cache/disk_cache_test_base.cc View 5 chunks +7 lines, -26 lines 0 comments Download
MM net/disk_cache/entry_impl.h View 2 chunks +2 lines, -15 lines 0 comments Download
MM net/disk_cache/entry_impl.cc View 13 chunks +40 lines, -117 lines 0 comments Download
MM net/disk_cache/entry_unittest.cc View 12 chunks +25 lines, -33 lines 0 comments Download
MM net/disk_cache/eviction.cc View 3 chunks +3 lines, -3 lines 0 comments Download
MM net/disk_cache/file_posix.cc View 4 chunks +2 lines, -11 lines 0 comments Download
D net/disk_cache/in_flight_backend_io.h View 1 chunk +0 lines, -200 lines 0 comments Download
D net/disk_cache/in_flight_backend_io.cc View 1 chunk +0 lines, -448 lines 0 comments Download
D net/disk_cache/in_flight_io.h View 1 chunk +0 lines, -128 lines 0 comments Download
D net/disk_cache/in_flight_io.cc View 1 chunk +0 lines, -64 lines 0 comments Download
MM net/disk_cache/sparse_control.cc View 4 chunks +5 lines, -5 lines 0 comments Download
MM net/disk_cache/stress_cache.cc View 1 chunk +1 line, -0 lines 0 comments Download
MM net/net.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
MM net/tools/crash_cache/crash_cache.cc View 12 chunks +5 lines, -25 lines 0 comments Download
MM net/tools/dump_cache/upgrade.cc View 6 chunks +12 lines, -33 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
rvargas (doing something else)
10 years, 5 months ago (2010-07-01 01:09:43 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698