Issue 281903002: Remove obsolete kiosk new window blocking code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 281903002: Remove obsolete kiosk new window blocking code. (Closed)

Created:
6 years, 7 months ago by xiyuan

Modified:
6 years, 7 months ago

Reviewers:
zel

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove obsolete kiosk new window blocking code. New window blocking for kiosk is done by a browser list observer now. The blocking code in CanCreateWindow is no longer needed. And it prevents webview's newwindow event being fired in kiosk mode. BUG=373023 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270326

Patch Set 1 #

Patch Set 2 : remove header #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -7 lines)			Patch
	M	chrome/browser/chrome_content_browser_client.cc	View	1	2 chunks	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/281903002/20001

6 years, 7 months ago (2014-05-13 23:06:51 UTC) #5

Message was sent while issue was closed.

Change committed as 270326

Expand Messages | Collapse Messages