Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(493)

Issue 2819009: Change include paths to reflect new directory. (Closed)

Created:
8 years ago by sosa
Modified:
7 years ago
Reviewers:
kmixter1
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://git@chromiumos-git//crash-reporter.git
Visibility:
Public.

Description

Change include paths to reflect new directory. TEST=Tested with new ebuild.

Patch Set 1 #

Patch Set 2 : Fix a cpl others #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M crash_reporter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M system_logging.cc View 1 chunk +1 line, -1 line 0 comments Download
M system_logging_mock.h View 1 chunk +1 line, -1 line 0 comments Download
M user_collector.h View 1 chunk +1 line, -1 line 0 comments Download
M user_collector.cc View 1 chunk +1 line, -1 line 0 comments Download
M user_collector_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sosa
8 years ago (2010-06-18 00:10:28 UTC) #1
kmixter1
8 years ago (2010-06-18 03:43:05 UTC) #2
LGTM

On Thu, Jun 17, 2010 at 5:10 PM,  <sosa@chromium.org> wrote:
> Reviewers: kmixter1,
>
> Description:
> Change include paths to reflect new directory.
>
> TEST=Tested with new ebuild.
>
> Please review this at http://codereview.chromium.org/2819009/show
>
> SVN Base: ssh://git@chromiumos-git//crash-reporter.git
>
> Affected files:
>  M crash_reporter.cc
>  M system_logging.cc
>  M system_logging_mock.h
>  M user_collector.h
>  M user_collector.cc
>  M user_collector_test.cc
>
>
> Index: crash_reporter.cc
> diff --git a/crash_reporter.cc b/crash_reporter.cc
> index
>
e283322dab15b1c2c1640866755bd6bf5f7fe182..87d4facf56897906ef9fc869a0d0ce680f504900
> 100644
> --- a/crash_reporter.cc
> +++ b/crash_reporter.cc
> @@ -7,8 +7,8 @@
>  #include "base/file_util.h"
>  #include "base/logging.h"
>  #include "base/string_util.h"
> -#include "crash/system_logging.h"
> -#include "crash/user_collector.h"
> +#include "crash-reporter/system_logging.h"
> +#include "crash-reporter/user_collector.h"
>  #include "gflags/gflags.h"
>  #include "metrics/metrics_library.h"
>
> Index: system_logging.cc
> diff --git a/system_logging.cc b/system_logging.cc
> index
>
e366ef2c2d197ee7346c47c33c3923c36987d81b..578951418500d2f2d7782f327a1d13fe3bdf1418
> 100644
> --- a/system_logging.cc
> +++ b/system_logging.cc
> @@ -5,7 +5,7 @@
>  #include <stdarg.h>
>  #include <syslog.h>
>
> -#include "crash/system_logging.h"
> +#include "crash-reporter/system_logging.h"
>
>  std::string SystemLoggingImpl::identity_;
>
> Index: system_logging_mock.h
> diff --git a/system_logging_mock.h b/system_logging_mock.h
> index
>
983c724672a4ff503d62ff3af9a19cab7f51e259..191e5313266c931ba2195efaec5cfaacfbaf2464
> 100644
> --- a/system_logging_mock.h
> +++ b/system_logging_mock.h
> @@ -7,7 +7,7 @@
>
>  #include <string>
>
> -#include "crash/system_logging.h"
> +#include "crash-reporter/system_logging.h"
>
>  class SystemLoggingMock : public SystemLogging {
>  public:
> Index: user_collector.cc
> diff --git a/user_collector.cc b/user_collector.cc
> index
>
7033ada1133c586c9b5f30988bc542a8bd4cca05..918f6910acb9f1af174a2c490913e41982a3e6bd
> 100644
> --- a/user_collector.cc
> +++ b/user_collector.cc
> @@ -7,7 +7,7 @@
>  #include "base/file_util.h"
>  #include "base/logging.h"
>  #include "base/string_util.h"
> -#include "crash/user_collector.h"
> +#include "crash-reporter/user_collector.h"
>  #include "metrics/metrics_library.h"
>
>  // This procfs file is used to cause kernel core file writing to
> Index: user_collector.h
> diff --git a/user_collector.h b/user_collector.h
> index
>
7f632246ab6d33452a397735a0a0c3289f02c268..0d5dd01c40b7386d62df2180dd843b3ac5d913ce
> 100644
> --- a/user_collector.h
> +++ b/user_collector.h
> @@ -7,7 +7,7 @@
>
>  #include <string>
>
> -#include "crash/system_logging.h"
> +#include "crash-reporter/system_logging.h"
>
>  class FilePath;
>
> Index: user_collector_test.cc
> diff --git a/user_collector_test.cc b/user_collector_test.cc
> index
>
6398ce707ea7ae362061dc796dc6502a7124624d..71cce62f4903a7a38cbd2d67e665887068389f7f
> 100644
> --- a/user_collector_test.cc
> +++ b/user_collector_test.cc
> @@ -6,8 +6,8 @@
>  #include <gtest/gtest.h>
>
>  #include "base/file_util.h"
> -#include "crash/system_logging_mock.h"
> -#include "crash/user_collector.h"
> +#include "crash-reporter/system_logging_mock.h"
> +#include "crash-reporter/user_collector.h"
>
>  int s_crashes = 0;
>  bool s_metrics = false;
>
>
>

Powered by Google App Engine
This is Rietveld 408576698