Fix #28740 demangle constructors in stack traces (A.A becomes new A).

Fix #28740 demangle constructors in stack traces (A.A becomes new A).

Regular constructors and unnamed factory constructors:
- Were A.A, now are new A
Named constructors (including factory constructors):
- Were A.A.name, now are new A.name

BUG=
R=asiva@google.com, rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/a84b6b7f7bf486b1189eb69c3a6ae2ee185c8d8a

[mfairhurst, 2017-04-14 20:59:51]

mfairhurst@google.com changed reviewers:
+ asiva@google.com, rmacnak@google.com, vegorov@google.com

[mfairhurst, 2017-04-14 20:59:51]

Found some time today to take a look at this, since it seemed like it would be
an easy one.

Hopefully all looks good!

[rmacnak, 2017-04-14 23:27:17]

lgtm w/ status file updates

 - Test fails in product mode because names are not scrubbed in product mode.
 - Test fails in dart2js because their stack traces are basically never
compliant.

See tests/language.status (for the VM in product mode) and
tests/language_dart2js.status (for dart2js).

https://codereview.chromium.org/2818933003/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/2818933003/diff/1/runtime/vm/object.cc#newcod...
runtime/vm/object.cc:7150: if (IsGenerativeConstructor() || IsFactory()) {
if (kind() == RawFunction::kConstructor) {

[siva, 2017-04-15 01:05:59]

https://codereview.chromium.org/2818933003/diff/1/tests/language/stacktrace_d...
File tests/language/stacktrace_demangle_ctors_test.dart (right):

https://codereview.chromium.org/2818933003/diff/1/tests/language/stacktrace_d...
tests/language/stacktrace_demangle_ctors_test.dart:1: // Copyright (c) 2013, the
Dart project authors.  Please see the AUTHORS file
2017

https://codereview.chromium.org/2818933003/diff/1/tests/language/stacktrace_d...
tests/language/stacktrace_demangle_ctors_test.dart:5: // Test that a stack trace
is properly terminated (issue 8850).
The comment here does not seem to match the intended fix.

[mfairhurst, 2017-04-18 20:45:53]

I think all feedback implemented -- would appreciate a look over the status
updates. Ran dart2js tests and product tests successfully, I think. (the former
gave me +1, and the latter printed nothing but required removing some
dart:mirrors imports in third_party to build)

[siva, 2017-04-18 22:15:06]

lgtm

[mfairhurst, 2017-04-18 22:18:36]

Description was changed from

==========
Fix #28740 demangle constructors in stack traces (A.A becomes new A).

Regular constructors and unnamed factory constructors:
- Were A.A, now are new A
Named constructors (including factory constructors):
- Were A.A.name, now are new A.name

BUG=
==========

to

==========
Fix #28740 demangle constructors in stack traces (A.A becomes new A).

Regular constructors and unnamed factory constructors:
- Were A.A, now are new A
Named constructors (including factory constructors):
- Were A.A.name, now are new A.name

BUG=
R=asiva@google.com, rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a84b6b7f7bf486b1189eb69c3a6ae2ee185c8d8a
==========

[mfairhurst, 2017-04-18 22:18:37]

Committed patchset #2 (id:20001) manually as
a84b6b7f7bf486b1189eb69c3a6ae2ee185c8d8a (presubmit successful).