Issue 281893002: Mojo: Base our epsilon timeouts off of TestTimeouts::tiny_timeout().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 281893002: Mojo: Base our epsilon timeouts off of TestTimeouts::tiny_timeout(). (Closed)

Created:
6 years, 7 months ago by viettrungluu

Modified:
6 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mojo: Base our epsilon timeouts off of TestTimeouts::tiny_timeout(). It's still a very small timeout, but at least it'll be adjusted (somewhat) for ASAN, and can be controlled via a command-line flag. Also switch to using base::TimeDelta instead of int64_t micros. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270303

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+193 lines, -223 lines)			Patch
M	mojo/system/message_pipe_dispatcher_unittest.cc	View	11 chunks	+24 lines, -32 lines	0 comments	Download
M	mojo/system/simple_dispatcher_unittest.cc	View	26 chunks	+58 lines, -79 lines	0 comments	Download
M	mojo/system/test_utils.h	View	3 chunks	+18 lines, -9 lines	0 comments	Download
M	mojo/system/test_utils.cc	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	mojo/system/waiter_list_unittest.cc	View	12 chunks	+15 lines, -26 lines	0 comments	Download
M	mojo/system/waiter_unittest.cc	View	9 chunks	+69 lines, -77 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/281893002/1

6 years, 7 months ago (2014-05-13 23:17:07 UTC) #4

Message was sent while issue was closed.

Change committed as 270303

Expand Messages | Collapse Messages