Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2818903002: [wasm] Handle no memory case when memory is exported

Created:
3 years, 8 months ago by gdeepti
Modified:
3 years, 8 months ago
Reviewers:
bradnelson
CC:
v8-reviews_googlegroups.com, wasm-v8_google.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Handle no memory case when memory is exported BUG=chromium:710844 R=bradnelson@chromium.org

Patch Set 1 #

Patch Set 2 : Add test #

Patch Set 3 : q #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -9 lines) Patch
M src/wasm/wasm-module.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M src/wasm/wasm-objects.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/wasm/wasm-objects.cc View 1 2 3 chunks +8 lines, -6 lines 0 comments Download
M test/mjsunit/regress/wasm/regression-699485.js View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/wasm/regression-710844.js View 1 2 1 chunk +23 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2823953002 Patch 1

Messages

Total messages: 10 (10 generated)
gdeepti
The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-14 00:37:55 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2818903002/1
3 years, 8 months ago (2017-04-14 00:37:58 UTC) #2
gdeepti
The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-14 00:54:47 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2818903002/20001
3 years, 8 months ago (2017-04-14 00:54:58 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-14 01:26:24 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 8 months ago (2017-04-14 01:26:25 UTC) #6
gdeepti
The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-17 23:27:34 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2818903002/40001
3 years, 8 months ago (2017-04-17 23:27:42 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-17 23:53:44 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-17 23:53:45 UTC) #10 
Dry run: Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/24522)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

Powered by Google App Engine
This is Rietveld 408576698