Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: third_party/WebKit/Source/web/InspectorOverlay.cpp

Issue 2818883002: [DevTools] Swallow mouse up in inspect mode (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/InspectorOverlay.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/InspectorOverlay.cpp
diff --git a/third_party/WebKit/Source/web/InspectorOverlay.cpp b/third_party/WebKit/Source/web/InspectorOverlay.cpp
index 3954ddced19d0a5f26d46eb7fbc5dd90bdb74a64..2eb72cfb4db52a9fda23a376a1fddfcb112e25d5 100644
--- a/third_party/WebKit/Source/web/InspectorOverlay.cpp
+++ b/third_party/WebKit/Source/web/InspectorOverlay.cpp
@@ -263,7 +263,9 @@ bool InspectorOverlay::HandleInputEvent(const WebInputEvent& input_event) {
if (mouse_event.GetType() == WebInputEvent::kMouseMove)
handled = HandleMouseMove(mouse_event);
else if (mouse_event.GetType() == WebInputEvent::kMouseDown)
- handled = HandleMousePress();
+ handled = HandleMouseDown();
+ else if (mouse_event.GetType() == WebInputEvent::kMouseUp)
+ handled = HandleMouseUp();
if (handled)
return true;
@@ -766,7 +768,11 @@ bool InspectorOverlay::HandleMouseMove(const WebMouseEvent& event) {
return true;
}
-bool InspectorOverlay::HandleMousePress() {
+bool InspectorOverlay::HandleMouseDown() {
+ return ShouldSearchForNode();
pfeldman 2017/04/14 00:37:39 As of this moment, don't update hovered_node_for_i
+}
+
+bool InspectorOverlay::HandleMouseUp() {
if (!ShouldSearchForNode())
return false;
« no previous file with comments | « third_party/WebKit/Source/web/InspectorOverlay.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698