Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: content/public/test/android/javatests/src/org/chromium/content/browser/test/ChildProcessAllocatorSettingsHook.java

Issue 2818643002: Support ChildProcessAllocatorSettings in JUnit4 tests (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/test/android/javatests/src/org/chromium/content/browser/test/ChildProcessAllocatorSettingsHook.java
diff --git a/content/public/test/android/javatests/src/org/chromium/content/browser/test/ChildProcessAllocatorSettingsHook.java b/content/public/test/android/javatests/src/org/chromium/content/browser/test/ChildProcessAllocatorSettingsHook.java
index ab42403895d40caf4b0c1346debb638c6303ddd1..c0976f651fda8ac90cbb7eecdc5fb700f4db6134 100644
--- a/content/public/test/android/javatests/src/org/chromium/content/browser/test/ChildProcessAllocatorSettingsHook.java
+++ b/content/public/test/android/javatests/src/org/chromium/content/browser/test/ChildProcessAllocatorSettingsHook.java
@@ -11,14 +11,18 @@ import org.chromium.content.browser.ChildConnectionAllocator;
import java.lang.reflect.Method;
-/** PreTestHook used to register the ChildProcessAllocatorSettings annotation. */
+/**
+ * PreTestHook used to register the ChildProcessAllocatorSettings annotation.
+ *
+ * TODO(yolandyan): convert this to TestRule once content tests are changed JUnit4
+ * */
public final class ChildProcessAllocatorSettingsHook implements PreTestHook {
@Override
public void run(Context targetContext, Method testMethod) {
ChildProcessAllocatorSettings annotation =
testMethod.getAnnotation(ChildProcessAllocatorSettings.class);
if (annotation != null) {
- ChildConnectionAllocator.setSanboxServicesSettingsForTesting(
+ ChildConnectionAllocator.setSandboxServicesSettingsForTesting(
annotation.sandboxedServiceCount(), annotation.sandboxedServiceName());
}
}

Powered by Google App Engine
This is Rietveld 408576698