content/public/android/java/src/org/chromium/content/browser/ChildConnectionAllocator.java - Issue 2818643002: Support ChildProcessAllocatorSettings in JUnit4 tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ChildConnectionAllocator.java

Issue 2818643002: Support ChildProcessAllocatorSettings in JUnit4 tests (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeInstrumentationTestRunner.java ('k') | content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ChildConnectionAllocator.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ChildConnectionAllocator.java b/content/public/android/java/src/org/chromium/content/browser/ChildConnectionAllocator.java

index 56230dda2078ccb330c5718391e25141d9819937..43c03676d76457c78e2ae155bebffc9f627ee3ce 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ChildConnectionAllocator.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ChildConnectionAllocator.java

@@ -145,7 +145,7 @@ public class ChildConnectionAllocator {

-1);

}

} catch (PackageManager.NameNotFoundException e) {

- throw new RuntimeException("Could not get application info");

+ throw new RuntimeException("Could not get application info", e);

}

if (numServices < 0) {

@@ -155,7 +155,7 @@ public class ChildConnectionAllocator {

}

@VisibleForTesting

- public static void setSanboxServicesSettingsForTesting(int serviceCount, String serviceName) {

+ public static void setSandboxServicesSettingsForTesting(int serviceCount, String serviceName) {

sSandboxedServicesCountForTesting = serviceCount;

sSandboxedServicesNameForTesting = serviceName;

}