Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Unified Diff: extensions/common/api/networking_private.idl

Issue 2818593003: [CrOS Tether] Add tether network properties (battery percentage, carrier, and signal strength) to t… (Closed)
Patch Set: stevenjb@ comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/api/networking_private.idl
diff --git a/extensions/common/api/networking_private.idl b/extensions/common/api/networking_private.idl
index 3cd81883fa9c173f84c50147485b3f8c30eddbab..cdefec106ad03eacaa6639261fbb3be3a8c2ae72 100644
--- a/extensions/common/api/networking_private.idl
+++ b/extensions/common/api/networking_private.idl
@@ -58,7 +58,7 @@ namespace networkingPrivate {
};
enum NetworkType {
- All, Cellular, Ethernet, VPN, Wireless, WiFi, WiMAX
+ All, Cellular, Ethernet, Tether, VPN, Wireless, WiFi, WiMAX
};
enum ProxySettingsType {
@@ -202,14 +202,14 @@ namespace networkingPrivate {
DOMString? CommonName;
DOMString? Locality;
DOMString? Organization;
- DOMString? OrganizationalUnit;
+ DOMString? OrganizationalUnit;
};
dictionary ManagedIssuerSubjectPattern {
ManagedDOMString? CommonName;
ManagedDOMString? Locality;
ManagedDOMString? Organization;
- ManagedDOMString? OrganizationalUnit;
+ ManagedDOMString? OrganizationalUnit;
};
dictionary CertificatePattern {
@@ -574,6 +574,18 @@ namespace networkingPrivate {
DOMString Authentication;
};
+ dictionary TetherProperties {
+ long BatteryPercentage;
stevenjb 2017/04/18 20:41:19 This is optional, right? Same with SignalStrength?
Kyle Horimoto 2017/04/18 21:58:39 No, these should always be present. They are alway
stevenjb 2017/04/18 22:23:06 In the ONC validation code you treat these as opti
+ DOMString Carrier;
+ long SignalStrength;
+ };
+
+ dictionary ManagedTetherProperties {
+ ManagedLong BatteryPercentage;
stevenjb 2017/04/18 20:41:19 ditto
Kyle Horimoto 2017/04/18 21:58:39 Same.
+ ManagedDOMString Carrier;
+ ManagedLong SignalStrength;
+ };
+
dictionary VPNProperties {
boolean? AutoConnect;
DOMString? Host;
@@ -689,6 +701,7 @@ namespace networkingPrivate {
IPConfigProperties? StaticIPConfig;
IPConfigProperties? SavedIPConfig;
DOMString? Source;
+ TetherProperties? Tether;
NetworkType Type;
VPNProperties? VPN;
WiFiProperties? WiFi;
@@ -713,6 +726,7 @@ namespace networkingPrivate {
ManagedIPConfigProperties? StaticIPConfig;
IPConfigProperties? SavedIPConfig;
DOMString? Source;
+ ManagedTetherProperties? Tether;
NetworkType Type;
ManagedVPNProperties? VPN;
ManagedWiFiProperties? WiFi;
@@ -729,6 +743,7 @@ namespace networkingPrivate {
DOMString? Name;
long? Priority;
DOMString? Source;
+ TetherProperties? Tether;
NetworkType Type;
VPNStateProperties? VPN;
WiFiStateProperties? WiFi;

Powered by Google App Engine
This is Rietveld 408576698