Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: chromeos/network/network_type_pattern_unittest.cc

Issue 2818593003: [CrOS Tether] Add tether network properties (battery percentage, carrier, and signal strength) to t… (Closed)
Patch Set: stevenjb@ comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/network_type_pattern_unittest.cc
diff --git a/chromeos/network/network_type_pattern_unittest.cc b/chromeos/network/network_type_pattern_unittest.cc
index 0003d8a6025607d48d51f71d9810286086761f73..68da7d1c03c6ff706b716b93e75cf31a84134e13 100644
--- a/chromeos/network/network_type_pattern_unittest.cc
+++ b/chromeos/network/network_type_pattern_unittest.cc
@@ -4,6 +4,7 @@
#include "chromeos/network/network_type_pattern.h"
+#include "chromeos/network/tether_constants.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/cros_system_api/dbus/service_constants.h"
@@ -53,7 +54,7 @@ TEST_F(NetworkTypePatternTest, MatchesType) {
EXPECT_TRUE(wireless_.MatchesType(shill::kTypeWimax));
EXPECT_FALSE(wireless_.MatchesType(shill::kTypeEthernet));
- EXPECT_FALSE(wireless_.MatchesType(kTypeTether));
+ EXPECT_TRUE(wireless_.MatchesType(kTypeTether));
EXPECT_FALSE(wimax_.MatchesType(kTypeTether));
}
@@ -74,7 +75,7 @@ TEST_F(NetworkTypePatternTest, MatchesPattern) {
EXPECT_TRUE(MatchesPattern(non_virtual_, ethernet_));
EXPECT_FALSE(MatchesPattern(cellular_, ethernet_));
- EXPECT_FALSE(MatchesPattern(tether_, wireless_));
+ EXPECT_TRUE(MatchesPattern(tether_, wireless_));
EXPECT_FALSE(MatchesPattern(tether_, non_virtual_));
// Default matches anything.

Powered by Google App Engine
This is Rietveld 408576698