Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: chromeos/network/onc/onc_validator_unittest.cc

Issue 2818593003: [CrOS Tether] Add tether network properties (battery percentage, carrier, and signal strength) to t… (Closed)
Patch Set: Ran git cl format. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/network/onc/onc_validator.cc ('k') | chromeos/network/tether_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/onc/onc_validator_unittest.cc
diff --git a/chromeos/network/onc/onc_validator_unittest.cc b/chromeos/network/onc/onc_validator_unittest.cc
index 0452b2c07e84986aa448a90b38929311df1ee6ee..92b3c879e7de449d62010603efa5991a5430729a 100644
--- a/chromeos/network/onc/onc_validator_unittest.cc
+++ b/chromeos/network/onc/onc_validator_unittest.cc
@@ -222,7 +222,8 @@ INSTANTIATE_TEST_CASE_P(
false),
OncParams("third_party_vpn.onc",
&kNetworkConfigurationSignature,
- false)));
+ false),
+ OncParams("tether.onc", &kNetworkWithStateSignature, false)));
namespace {
@@ -551,6 +552,34 @@ INSTANTIATE_TEST_CASE_P(
std::make_pair(OncParams("openvpn-invalid-verify-x509-type",
&kNetworkConfigurationSignature,
false),
+ ExpectBothNotValid("", "")),
+ std::make_pair(OncParams("tether-missing-battery-percentage",
+ &kNetworkWithStateSignature,
+ true),
+ ExpectBothNotValid("", "")),
+ std::make_pair(OncParams("tether-negative-battery",
+ &kNetworkWithStateSignature,
+ true),
+ ExpectBothNotValid("", "")),
+ std::make_pair(OncParams("tether-battery-over-100",
+ &kNetworkWithStateSignature,
+ true),
+ ExpectBothNotValid("", "")),
+ std::make_pair(OncParams("tether-missing-carrier",
+ &kNetworkWithStateSignature,
+ true),
+ ExpectBothNotValid("", "")),
+ std::make_pair(OncParams("tether-missing-signal-strength",
+ &kNetworkWithStateSignature,
+ true),
+ ExpectBothNotValid("", "")),
+ std::make_pair(OncParams("tether-negative-signal-strength",
+ &kNetworkWithStateSignature,
+ true),
+ ExpectBothNotValid("", "")),
+ std::make_pair(OncParams("tether-signal-strength-over-100",
+ &kNetworkWithStateSignature,
+ true),
ExpectBothNotValid("", ""))));
} // namespace onc
« no previous file with comments | « chromeos/network/onc/onc_validator.cc ('k') | chromeos/network/tether_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698