Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Unified Diff: third_party/WebKit/LayoutTests/shapedetection/detection-options.html

Issue 2818563006: ShapeDetection: Holding all of mock service to prevent GC (Closed)
Patch Set: ShapeDetection: Holding the MockFaceDetection to prevent Binding Object to be GCd Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/shapedetection/detection-options.html
diff --git a/third_party/WebKit/LayoutTests/shapedetection/detection-options.html b/third_party/WebKit/LayoutTests/shapedetection/detection-options.html
index fb12e70d34d88b462735e3de2da9c1b1e2cc0980..8738dfcfece01646f3f1d4ec3ce7271e87e5f8ab 100644
--- a/third_party/WebKit/LayoutTests/shapedetection/detection-options.html
+++ b/third_party/WebKit/LayoutTests/shapedetection/detection-options.html
@@ -20,14 +20,14 @@ async_test(function(t) {
})
.then(detectorWithDefault => detectorWithDefault.detect(img))
.then(t.step_func(faceDetectionResult => {
- assert_equals(theMock.getMaxDetectedFaces(), 10, "default maxDetectedFaces");
- assert_equals(theMock.getFastMode(), false, "default maxDetectedFaces");
+ assert_equals(theMock.getMaxDetectedFaces(0), 10, "default maxDetectedFaces");
+ assert_equals(theMock.getFastMode(0), false, "default maxDetectedFaces");
return new FaceDetector({maxDetectedFaces: 7, fastMode: true});
}))
.then(detectorWithOptions => detectorWithOptions.detect(img))
.then(t.step_func(faceDetectionResult => {
- assert_equals(theMock.getMaxDetectedFaces(), 7, "maxDetectedFaces");
- assert_equals(theMock.getFastMode(), true, "maxDetectedFaces");
+ assert_equals(theMock.getMaxDetectedFaces(1), 7, "maxDetectedFaces");
+ assert_equals(theMock.getFastMode(1), true, "maxDetectedFaces");
t.done();
}))
.catch(error => {

Powered by Google App Engine
This is Rietveld 408576698