third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html - Issue 2818563006: ShapeDetection: Holding all of mock service to prevent GC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html

Issue 2818563006: ShapeDetection: Holding all of mock service to prevent GC (Closed)

Patch Set: ShapeDetection: Holding the MockFaceDetection to prevent Binding Object to be GCd Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html » ('j') | third_party/WebKit/LayoutTests/shapedetection/resources/mock-facedetection.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html

diff --git a/third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html b/third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html

index f5f692ce20589a1744e057d39713e62428878d4e..838c36cfc1754f8c53e5633973eca605d96e0c86 100644

--- a/third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html

+++ b/third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html

@@ -46,7 +46,7 @@ var createTestForCanvasElement = function(createDetector,

};

function FaceDetectorDetectionResultTest(detectionResult, mock) {

- const imageReceivedByMock = mock.getFrameData();

+ const imageReceivedByMock = mock.getFrameData(0);

assert_equals(imageReceivedByMock.byteLength, 180000,"Image length");

const GREEN_PIXEL = 0xFF00FF00;

assert_equals(imageReceivedByMock[0], GREEN_PIXEL, "Pixel color");