Issue 2818543002: [Reapply] Pass ElementImpl as a context for resynthesizing types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2818543002: [Reapply] Pass ElementImpl as a context for resynthesizing types. (Closed)

Created:
3 years, 8 months ago by scheglov

Modified:
3 years, 8 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

[Reapply] Pass ElementImpl as a context for resynthesizing types. I added a couple of changes for link.dart to use context in getLinkedType(). I was not able to create a unit test for this case :-/ R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/5f28891e617cb109ba3e7a5849dfcb791b8ae3a7

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+162 lines, -98 lines)			Patch
M	pkg/analyzer/lib/src/dart/element/element.dart	View	16 chunks	+30 lines, -39 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/link.dart	View	18 chunks	+32 lines, -26 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/resynthesize.dart	View	9 chunks	+24 lines, -33 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/resynthesize_common.dart	View	1 chunk	+76 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

3 years, 8 months ago (2017-04-12 18:54:31 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5f28891e617cb109ba3e7a5849dfcb791b8ae3a7 (presubmit successful).