ui/aura/window_event_dispatcher_unittest.cc - Issue 2818533003: Make nesting/running states a RunLoop rather than a MessageLoop concept.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/aura/window_event_dispatcher_unittest.cc

Issue 2818533003: Make nesting/running states a RunLoop rather than a MessageLoop concept. (Closed)

Patch Set: still need to check MessageLoop::current() in Mojo's RunLoopNestingObserver::GetForThread() Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/aura/window_event_dispatcher_unittest.cc

diff --git a/ui/aura/window_event_dispatcher_unittest.cc b/ui/aura/window_event_dispatcher_unittest.cc

index 3d4e153ca6ed61cb3eca7b448e3b23c377f4c875..135849f1ca6e97557ffac69a31c8ea7ed9b27c34 100644

--- a/ui/aura/window_event_dispatcher_unittest.cc

+++ b/ui/aura/window_event_dispatcher_unittest.cc

@@ -2116,7 +2116,7 @@ class WindowEventDispatcherTestWithMessageLoop

};

TEST_P(WindowEventDispatcherTestWithMessageLoop, EventRepostedInNonNestedLoop) {

- CHECK(!message_loop()->is_running());

+ ASSERT_FALSE(base::RunLoop::IsRunningOnCurrentThread());

// Perform the test in a callback, so that it runs after the message-loop

// starts.

message_loop()->task_runner()->PostTask(

« no previous file with comments | « ui/aura/mus/window_tree_client.cc ('k') | no next file » | no next file with comments »