device/bluetooth/test/test_bluetooth_adapter_observer.cc - Issue 2818533003: Make nesting/running states a RunLoop rather than a MessageLoop concept.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/test/test_bluetooth_adapter_observer.cc

Issue 2818533003: Make nesting/running states a RunLoop rather than a MessageLoop concept. (Closed)

Patch Set: still need to check MessageLoop::current() in Mojo's RunLoopNestingObserver::GetForThread() Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/bluetooth/test/test_bluetooth_adapter_observer.cc

diff --git a/device/bluetooth/test/test_bluetooth_adapter_observer.cc b/device/bluetooth/test/test_bluetooth_adapter_observer.cc

index 1ab083060d2bc1f54493d8542a476a13c38d5af4..ed01c5093a9bccf7873bce559ce333f2135e3259 100644

--- a/device/bluetooth/test/test_bluetooth_adapter_observer.cc

+++ b/device/bluetooth/test/test_bluetooth_adapter_observer.cc

@@ -8,6 +8,7 @@

#include <vector>

#include "base/message_loop/message_loop.h"

+#include "base/run_loop.h"

#include "device/bluetooth/bluetooth_remote_gatt_characteristic.h"

#include "device/bluetooth/bluetooth_remote_gatt_descriptor.h"

#include "device/bluetooth/bluetooth_remote_gatt_service.h"

@@ -333,8 +334,7 @@ void TestBluetoothAdapterObserver::GattDescriptorValueChanged(

}

void TestBluetoothAdapterObserver::QuitMessageLoop() {

- if (base::MessageLoop::current() &&

- base::MessageLoop::current()->is_running())

+ if (base::RunLoop::IsRunningOnCurrentThread())

base::MessageLoop::current()->QuitWhenIdle();

}