components/omnibox/browser/autocomplete_provider_unittest.cc - Issue 2818533003: Make nesting/running states a RunLoop rather than a MessageLoop concept.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/autocomplete_provider_unittest.cc

Issue 2818533003: Make nesting/running states a RunLoop rather than a MessageLoop concept. (Closed)

Patch Set: still need to check MessageLoop::current() in Mojo's RunLoopNestingObserver::GetForThread() Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/omnibox/browser/autocomplete_provider_unittest.cc

diff --git a/components/omnibox/browser/autocomplete_provider_unittest.cc b/components/omnibox/browser/autocomplete_provider_unittest.cc

index e3f3a3ffba289833ff12e808dd51ff2a5d8241c5..47107431409f337b2bd70a566c38b6b5e32ebe6d 100644

--- a/components/omnibox/browser/autocomplete_provider_unittest.cc

+++ b/components/omnibox/browser/autocomplete_provider_unittest.cc

@@ -74,7 +74,7 @@ class AutocompleteProviderClientWithClosure

AutocompleteController* controller) override {

if (!closure_.is_null())

closure_.Run();

- if (base::MessageLoop::current()->is_running())

+ if (base::RunLoop::IsRunningOnCurrentThread())

base::MessageLoop::current()->QuitWhenIdle();

}