storage/browser/fileapi/file_system_operation_impl_write_unittest.cc - Issue 2818533003: Make nesting/running states a RunLoop rather than a MessageLoop concept.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: storage/browser/fileapi/file_system_operation_impl_write_unittest.cc

Issue 2818533003: Make nesting/running states a RunLoop rather than a MessageLoop concept. (Closed)

Patch Set: need to RunUntilIdle for ConnectProfile with DoNothing callbacks -- how did this possibly not hang … Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« device/bluetooth/bluez/bluetooth_socket_bluez_unittest.cc ('K') | « services/ui/service.cc ('k') | third_party/WebKit/Source/core/frame/PerformanceMonitor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: storage/browser/fileapi/file_system_operation_impl_write_unittest.cc

diff --git a/storage/browser/fileapi/file_system_operation_impl_write_unittest.cc b/storage/browser/fileapi/file_system_operation_impl_write_unittest.cc

index ebc48d747cae7de6ae34d925ca4832cd1962408d..ab682226968b8f08fc8c4233d8ec5503c830fe86 100644

--- a/storage/browser/fileapi/file_system_operation_impl_write_unittest.cc

+++ b/storage/browser/fileapi/file_system_operation_impl_write_unittest.cc

@@ -139,7 +139,7 @@ class FileSystemOperationImplWriteTest : public testing::Test {

EXPECT_EQ(status_, base::File::FILE_OK);

complete_ = true;

status_ = status;

- if (base::MessageLoop::current()->is_running())

+ if (base::RunLoop::IsRunningOnCurrentThread())

base::MessageLoop::current()->QuitWhenIdle();

}