chrome/browser/browser_process_impl.cc - Issue 2818533003: Make nesting/running states a RunLoop rather than a MessageLoop concept.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browser_process_impl.cc

Issue 2818533003: Make nesting/running states a RunLoop rather than a MessageLoop concept. (Closed)

Patch Set: need to RunUntilIdle for ConnectProfile with DoNothing callbacks -- how did this possibly not hang … Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/browser_process_impl.cc

diff --git a/chrome/browser/browser_process_impl.cc b/chrome/browser/browser_process_impl.cc

index a0d1638fd5f2b85bb1981b1b0be0f4c7faf05893..4866d95f931bac0d66b5bf9cac7ffef8ee8e8f29 100644

--- a/chrome/browser/browser_process_impl.cc

+++ b/chrome/browser/browser_process_impl.cc

@@ -24,6 +24,7 @@

#include "base/metrics/field_trial.h"

#include "base/metrics/histogram_macros.h"

#include "base/path_service.h"

+#include "base/run_loop.h"

#include "base/single_thread_task_runner.h"

#include "base/synchronization/waitable_event.h"

#include "base/threading/sequenced_worker_pool.h"

@@ -1365,7 +1366,7 @@ void BrowserProcessImpl::Unpin() {

__lsan_do_leak_check();

#endif

- CHECK(base::MessageLoop::current()->is_running());

+ CHECK(base::RunLoop::IsRunningOnCurrentThread());

#if defined(OS_MACOSX)

base::ThreadTaskRunnerHandle::Get()->PostTask(