ui/aura/window_event_dispatcher_unittest.cc - Issue 2818533003: Make nesting/running states a RunLoop rather than a MessageLoop concept.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/aura/window_event_dispatcher_unittest.cc

Issue 2818533003: Make nesting/running states a RunLoop rather than a MessageLoop concept. (Closed)

Patch Set: Fix nesting observer issues with LazySchedulerMessageLoopDelegateForTests Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/aura/window_event_dispatcher_unittest.cc

diff --git a/ui/aura/window_event_dispatcher_unittest.cc b/ui/aura/window_event_dispatcher_unittest.cc

index b13935272fd4e1a5af37c23f3b60980292fb508e..b1001a8c1e25c1888f5fefaba1c2443b168034cc 100644

--- a/ui/aura/window_event_dispatcher_unittest.cc

+++ b/ui/aura/window_event_dispatcher_unittest.cc

@@ -2084,7 +2084,7 @@ class WindowEventDispatcherTestWithMessageLoop

};

TEST_P(WindowEventDispatcherTestWithMessageLoop, EventRepostedInNonNestedLoop) {

- CHECK(!message_loop()->is_running());

+ ASSERT_FALSE(base::RunLoop::IsRunningOnCurrentThread());

// Perform the test in a callback, so that it runs after the message-loop

// starts.

message_loop()->task_runner()->PostTask(