chromeos/dbus/services/service_provider_test_helper.cc - Issue 2818533003: Make nesting/running states a RunLoop rather than a MessageLoop concept.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/services/service_provider_test_helper.cc

Issue 2818533003: Make nesting/running states a RunLoop rather than a MessageLoop concept. (Closed)

Patch Set: fix compile and add RunLoopTests Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/dbus/services/service_provider_test_helper.cc

diff --git a/chromeos/dbus/services/service_provider_test_helper.cc b/chromeos/dbus/services/service_provider_test_helper.cc

index 698fd39d5a7a75c67e1ed5c381db49701690f04f..2868c8cd700e4ccc6bcb9e38a3cace6bbd9af696 100644

--- a/chromeos/dbus/services/service_provider_test_helper.cc

+++ b/chromeos/dbus/services/service_provider_test_helper.cc

@@ -160,7 +160,7 @@ void ServiceProviderTestHelper::OnResponse(

std::unique_ptr<dbus::Response> response) {

response_ = std::move(response);

response_received_ = true;

- if (base::MessageLoop::current()->is_running())

+ if (base::RunLoop::IsRunningOnCurrentThread())

base::MessageLoop::current()->QuitWhenIdle();

}