Improved isInteresting heuristic, made more AutomationNodes focusable

chrome/browser/resources/chromeos/switch_access/tree_walker.js

Index: chrome/browser/resources/chromeos/switch_access/tree_walker.js
diff --git a/chrome/browser/resources/chromeos/switch_access/tree_walker.js b/chrome/browser/resources/chromeos/switch_access/tree_walker.js
index ce8237d798caa62c4a6254fa95f20a4b5366199a..14bc04459aca2c88fee98d7fd45ded91feea371d 100644
--- a/chrome/browser/resources/chromeos/switch_access/tree_walker.js
+++ b/chrome/browser/resources/chromeos/switch_access/tree_walker.js
@@ -120,7 +120,25 @@ AutomationTreeWalker.prototype = {
    * @private
    */
   isInteresting_: function(node) {
-    return node.state && node.state.focusable;
+    let loc = node.location;
+    let parent = node.parent;
+    let role = node.role;
+    let state = node.state;
+
+    // Skip things that are offscreen
+    if (state.offscreen || loc.top < 0 || loc.left < 0)
+      return false;
+
+    if (parent) {
+      // crbug.com/710559
+      // Work around for browser tabs
+      if (role === chrome.automation.RoleType.TAB
+          && parent.role === chrome.automation.RoleType.TAB_LIST)

[David Tseng, 2017/04/12 17:37:46]

Note that these roles can occur in web pages as well. I would still check
focusability if the root is not DESKTOP if that's your intent here.

[elichtenberg, 2017/04/12 20:11:04]

Done.

+        return true;
+    }
+
+    // The general rule that applies to everything.
+    return state.focusable;
   },
 
   /**