Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2818463002: Remove Compiler and JavaScriptBackend from interceptor_stub_generator. (Closed)

Created:
3 years, 8 months ago by Johnni Winther
Modified:
3 years, 8 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove Compiler and JavaScriptBackend from interceptor_stub_generator. This is a step towards passing data object directly instead of accessing data on JavaScriptBackend. This is needed to support an element switch between resolution and codegen. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/db048990bc8dc0f3e2f1e89bb2d63fb410f9f7fc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -160 lines) Patch
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +0 lines, -20 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/interceptor_emitter.dart View 2 chunks +26 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart View 19 chunks +121 lines, -93 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 29 chunks +78 lines, -43 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 8 months ago (2017-04-12 13:57:31 UTC) #2
Emily Fortuna
lgtm
3 years, 8 months ago (2017-04-12 18:02:33 UTC) #3
Johnni Winther
3 years, 8 months ago (2017-04-18 08:34:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
db048990bc8dc0f3e2f1e89bb2d63fb410f9f7fc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698