Download favicon from server for suggested articles

ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.h"
 
 #include "base/logging.h"
 #include "base/mac/foundation_util.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/time/time.h"
@@ skipping 458 matching lines @@
 
   articleItem.suggestionIdentifier = suggestion.suggestionIdentifier;
 
   __weak ContentSuggestionsArticleItem* weakItem = articleItem;
   [self fetchFaviconForItem:articleItem
                     withURL:articleItem.articleURL
                    callback:^void(FaviconAttributes* attributes) {
                      weakItem.attributes = attributes;
                    }];
 
+  __weak ContentSuggestionsCollectionUpdater* weakSelf = self;
+  [self.dataSource
+      fetchFaviconImageForSuggestion:articleItem.suggestionIdentifier
+                          completion:^void(UIImage* favicon) {
+                            weakItem.attributes =

[lpromero, 2017/04/14 13:19:40]

I'd advise to return early if one of the weak items are nil, so that the
FaviconAttributes method doesn’t get called.
It will also avoid [weakSelf reconfigure:nil].

+                                [FaviconAttributes attributesWithImage:favicon];
+                            [weakSelf reconfigure:weakItem];
+                          }];
+
   return articleItem;
 }
 
 // Returns a reading list item built with the |suggestion|.
 - (ContentSuggestionsReadingListItem*)readingListItemForSuggestion:
     (ContentSuggestion*)suggestion {
   ContentSuggestionsReadingListItem* readingListItem =
       [[ContentSuggestionsReadingListItem alloc]
                initWithType:ItemTypeReadingList
                         url:suggestion.url
@@ skipping 64 matching lines @@
         [model sectionIdentifierForSection:sectionNumber];
     if ([model hasItem:item inSectionWithIdentifier:sectionIdentifier]) {
       [self.collectionViewController
           reconfigureCellsForItems:@[ item ]
            inSectionWithIdentifier:sectionIdentifier];
     }
   }
 }
 
 @end