content/browser/browser_plugin/browser_plugin_guest.h - Issue 281833003: BrowserPluginHostTest: Rewrite 3 focus related tests and 1 visibility test to browser_tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.h

Issue 281833003: BrowserPluginHostTest: Rewrite 3 focus related tests and 1 visibility test to browser_tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase @tott, fix conflict Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/platform_apps/web_view/shim/main.js ('k') | content/browser/browser_plugin/browser_plugin_host_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_plugin/browser_plugin_guest.h

diff --git a/content/browser/browser_plugin/browser_plugin_guest.h b/content/browser/browser_plugin/browser_plugin_guest.h

index 3b7dce91edb3e6ed76976018a0556d742ba47ba7..3f595e4450d6c696bf4230c764e9581bb45a9880 100644

--- a/content/browser/browser_plugin/browser_plugin_guest.h

+++ b/content/browser/browser_plugin/browser_plugin_guest.h

@@ -322,11 +322,12 @@ class CONTENT_EXPORT BrowserPluginGuest

void OnNavigateGuest(int instance_id, const std::string& src);

void OnPluginDestroyed(int instance_id);

// Resizes the guest's web contents.

- // Overridden in tests.

- virtual void OnResizeGuest(

+ void OnResizeGuest(

int instance_id, const BrowserPluginHostMsg_ResizeGuest_Params& params);

- // Overridden in tests.

- virtual void OnSetFocus(int instance_id, bool focused);

+ void OnSetFocus(int instance_id, bool focused);

+ // Sets the name of the guest so that other guests in the same partition can

+ // access it.

+ void OnSetName(int instance_id, const std::string& name);

// Updates the size state of the guest.

void OnSetSize(

int instance_id,

@@ -392,8 +393,10 @@ class CONTENT_EXPORT BrowserPluginGuest

void OnShowPopup(const ViewHostMsg_ShowPopup_Params& params);

#endif

void OnShowWidget(int route_id, const gfx::Rect& initial_pos);

- // Overridden in tests.

- virtual void OnTakeFocus(bool reverse);

+ void OnTakeFocus(bool reverse);

+ void OnUpdateFrameName(int frame_id,

+ bool is_top_level,

+ const std::string& name);

void OnUpdateRect(const ViewHostMsg_UpdateRect_Params& params);

// Forwards all messages from the |pending_messages_| queue to the embedder.