Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 281833002: Allow incrementally linked release builds on windows. (Closed)

Created:
6 years, 7 months ago by DaleCurtis
Modified:
6 years, 7 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Allow incrementally linked release builds on windows. This change allows incremental builds when incremental_chrome_dll==1 or transitively when component==shared_library. BUG=372983 TEST=Build release, touch file, observe not all dlls relinked. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270425

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M build/release.gypi View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
DaleCurtis
6 years, 7 months ago (2014-05-13 21:50:33 UTC) #1
scottmg
Cool, that was all of them? This works OK with build/internal/release_defaults.gypi? lgtm if trybots are ...
6 years, 7 months ago (2014-05-13 22:01:00 UTC) #2
DaleCurtis
Yup, it correctly overrides the values. I'll throw some tries at it now and see ...
6 years, 7 months ago (2014-05-13 22:02:57 UTC) #3
DaleCurtis
s/send a PSA/send a PSA and CQ/
6 years, 7 months ago (2014-05-13 22:03:17 UTC) #4
DaleCurtis
PSA sent. I'll land this tomorrow if there are no objections.
6 years, 7 months ago (2014-05-13 23:34:07 UTC) #5
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 7 months ago (2014-05-14 17:21:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/281833002/1
6 years, 7 months ago (2014-05-14 17:21:55 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-14 17:23:04 UTC) #8
Message was sent while issue was closed.
Change committed as 270425

Powered by Google App Engine
This is Rietveld 408576698