Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1470)

Unified Diff: remoting/codec/video_decoder_vpx_unittest.cc

Issue 28183002: Add VP9 encode support to the remoting host. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/codec/video_encoder_vpx.h » ('j') | remoting/codec/video_encoder_vpx.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/codec/video_decoder_vpx_unittest.cc
diff --git a/remoting/codec/video_decoder_vpx_unittest.cc b/remoting/codec/video_decoder_vpx_unittest.cc
index 6e31f0d4e19068fdca355b4d0891cda9974d93c7..0f3e3d2a0767998ef3f81ac67f64cfcc1802aa20 100644
--- a/remoting/codec/video_decoder_vpx_unittest.cc
+++ b/remoting/codec/video_decoder_vpx_unittest.cc
@@ -12,6 +12,8 @@
namespace remoting {
+namespace {
+
class VideoDecoderVpxTest : public testing::Test {
protected:
scoped_ptr<VideoEncoderVpx> encoder_;
@@ -32,49 +34,121 @@ class VideoDecoderVpxTest : public testing::Test {
}
};
-TEST_F(VideoDecoderVpxTest, VideoEncodeAndDecode) {
+class VideoDecoderVp8Test : public VideoDecoderVpxTest {
+ protected:
+ VideoDecoderVp8Test() {
+ encoder_ = VideoEncoderVpx::CreateForVP8();
+ decoder_ = VideoDecoderVpx::CreateForVP8();
+ }
+};
+
+class VideoDecoderVp9Test : public VideoDecoderVpxTest {
+ protected:
+ VideoDecoderVp9Test() {
+ encoder_ = VideoEncoderVpx::CreateForVP9();
+ decoder_ = VideoDecoderVpx::CreateForVP9();
+ }
+};
+
+} // namespace
+
+//
+// Test the VP8 codec.
+//
+
+TEST_F(VideoDecoderVp8Test, VideoEncodeAndDecode) {
+ TestVideoEncoderDecoder(encoder_.get(), decoder_.get(), false);
+}
+
+// Check that encoding and decoding a particular frame doesn't change the
+// frame too much. The frame used is a gradient, which does not contain sharp
+// transitions, so encoding lossiness should not be too high.
+TEST_F(VideoDecoderVp8Test, Gradient) {
+ TestGradient(320, 240, 320, 240, 0.04, 0.02);
+}
+
+TEST_F(VideoDecoderVp8Test, GradientScaleUpEvenToEven) {
+ TestGradient(320, 240, 640, 480, 0.04, 0.02);
+}
+
+TEST_F(VideoDecoderVp8Test, GradientScaleUpEvenToOdd) {
+ TestGradient(320, 240, 641, 481, 0.04, 0.02);
+}
+
+TEST_F(VideoDecoderVp8Test, GradientScaleUpOddToEven) {
+ TestGradient(321, 241, 640, 480, 0.04, 0.02);
+}
+
+TEST_F(VideoDecoderVp8Test, GradientScaleUpOddToOdd) {
+ TestGradient(321, 241, 641, 481, 0.04, 0.02);
+}
+
+TEST_F(VideoDecoderVp8Test, GradientScaleDownEvenToEven) {
+ TestGradient(320, 240, 160, 120, 0.04, 0.02);
+}
+
+TEST_F(VideoDecoderVp8Test, GradientScaleDownEvenToOdd) {
+ // The maximum error is non-deterministic. The mean error is not too high,
+ // which suggests that the problem is restricted to a small area of the output
+ // image. See crbug.com/139437 and crbug.com/139633.
+ TestGradient(320, 240, 161, 121, 1.0, 0.02);
+}
+
+TEST_F(VideoDecoderVp8Test, GradientScaleDownOddToEven) {
+ TestGradient(321, 241, 160, 120, 0.04, 0.02);
+}
+
+TEST_F(VideoDecoderVp8Test, GradientScaleDownOddToOdd) {
+ TestGradient(321, 241, 161, 121, 0.04, 0.02);
+}
+
+//
+// Test the VP9 codec.
+//
+
+TEST_F(VideoDecoderVp9Test, VideoEncodeAndDecode) {
TestVideoEncoderDecoder(encoder_.get(), decoder_.get(), false);
}
// Check that encoding and decoding a particular frame doesn't change the
// frame too much. The frame used is a gradient, which does not contain sharp
// transitions, so encoding lossiness should not be too high.
-TEST_F(VideoDecoderVpxTest, Gradient) {
+TEST_F(VideoDecoderVp9Test, Gradient) {
TestGradient(320, 240, 320, 240, 0.04, 0.02);
}
-TEST_F(VideoDecoderVpxTest, GradientScaleUpEvenToEven) {
+TEST_F(VideoDecoderVp9Test, GradientScaleUpEvenToEven) {
TestGradient(320, 240, 640, 480, 0.04, 0.02);
}
-TEST_F(VideoDecoderVpxTest, GradientScaleUpEvenToOdd) {
+TEST_F(VideoDecoderVp9Test, GradientScaleUpEvenToOdd) {
TestGradient(320, 240, 641, 481, 0.04, 0.02);
}
-TEST_F(VideoDecoderVpxTest, GradientScaleUpOddToEven) {
+TEST_F(VideoDecoderVp9Test, GradientScaleUpOddToEven) {
TestGradient(321, 241, 640, 480, 0.04, 0.02);
}
-TEST_F(VideoDecoderVpxTest, GradientScaleUpOddToOdd) {
+TEST_F(VideoDecoderVp9Test, GradientScaleUpOddToOdd) {
TestGradient(321, 241, 641, 481, 0.04, 0.02);
}
-TEST_F(VideoDecoderVpxTest, GradientScaleDownEvenToEven) {
+TEST_F(VideoDecoderVp9Test, GradientScaleDownEvenToEven) {
TestGradient(320, 240, 160, 120, 0.04, 0.02);
}
-TEST_F(VideoDecoderVpxTest, GradientScaleDownEvenToOdd) {
+TEST_F(VideoDecoderVp9Test, GradientScaleDownEvenToOdd) {
// The maximum error is non-deterministic. The mean error is not too high,
// which suggests that the problem is restricted to a small area of the output
// image. See crbug.com/139437 and crbug.com/139633.
TestGradient(320, 240, 161, 121, 1.0, 0.02);
}
-TEST_F(VideoDecoderVpxTest, GradientScaleDownOddToEven) {
+TEST_F(VideoDecoderVp9Test, GradientScaleDownOddToEven) {
TestGradient(321, 241, 160, 120, 0.04, 0.02);
}
-TEST_F(VideoDecoderVpxTest, GradientScaleDownOddToOdd) {
+TEST_F(VideoDecoderVp9Test, GradientScaleDownOddToOdd) {
TestGradient(321, 241, 161, 121, 0.04, 0.02);
}
« no previous file with comments | « no previous file | remoting/codec/video_encoder_vpx.h » ('j') | remoting/codec/video_encoder_vpx.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698