Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 28183002: Add VP9 encode support to the remoting host. (Closed)

Created:
7 years, 2 months ago by Wez
Modified:
6 years, 8 months ago
Reviewers:
Jamie
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update unit tests. #

Patch Set 3 : Rebase. #

Total comments: 6

Patch Set 4 : Update comments and choose a better cpu-used setting. #

Patch Set 5 : Switch to CPU-used == 4. #

Patch Set 6 : Prevent VP9 uglifying output via quantization. #

Patch Set 7 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -13 lines) Patch
M remoting/codec/video_decoder_vpx_unittest.cc View 1 2 3 2 chunks +84 lines, -10 lines 0 comments Download
M remoting/codec/video_encoder_vpx.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M remoting/codec/video_encoder_vpx.cc View 1 2 3 4 5 2 chunks +50 lines, -0 lines 0 comments Download
M remoting/codec/video_encoder_vpx_unittest.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/host/client_session.cc View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 31 (0 generated)
Wez
PTAL Note that this can't be landed until Chrome's libvpx is built with VP9 encode ...
7 years, 2 months ago (2013-10-21 05:26:56 UTC) #1
Jamie
https://codereview.chromium.org/28183002/diff/60001/remoting/codec/video_encoder_vpx.cc File remoting/codec/video_encoder_vpx.cc (right): https://codereview.chromium.org/28183002/diff/60001/remoting/codec/video_encoder_vpx.cc#newcode99 remoting/codec/video_encoder_vpx.cc:99: // encoding. You're not using 2 for VP9. Please ...
7 years, 2 months ago (2013-10-21 18:15:28 UTC) #2
Wez
https://codereview.chromium.org/28183002/diff/60001/remoting/codec/video_encoder_vpx.cc File remoting/codec/video_encoder_vpx.cc (right): https://codereview.chromium.org/28183002/diff/60001/remoting/codec/video_encoder_vpx.cc#newcode99 remoting/codec/video_encoder_vpx.cc:99: // encoding. On 2013/10/21 18:15:28, Jamie wrote: > You're ...
7 years, 2 months ago (2013-10-22 01:12:33 UTC) #3
Jamie
lgtm
7 years, 2 months ago (2013-10-22 01:22:29 UTC) #4
Wez
The CQ bit was checked by wez@chromium.org
6 years, 10 months ago (2014-02-08 02:33:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/28183002/260001
6 years, 10 months ago (2014-02-08 02:34:13 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-08 03:01:15 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=226583
6 years, 10 months ago (2014-02-08 03:01:15 UTC) #8
Wez
The CQ bit was checked by wez@chromium.org
6 years, 10 months ago (2014-02-10 19:44:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/28183002/260001
6 years, 10 months ago (2014-02-10 19:46:20 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-10 20:43:02 UTC) #11
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, cacheinvalidation_unittests, cc_unittests, check_deps, check_deps2git, ...
6 years, 10 months ago (2014-02-10 20:43:02 UTC) #12
Wez
The CQ bit was checked by wez@chromium.org
6 years, 9 months ago (2014-03-05 19:09:55 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/28183002/260001
6 years, 9 months ago (2014-03-05 19:10:56 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 20:30:52 UTC) #15
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=275534
6 years, 9 months ago (2014-03-05 20:30:53 UTC) #16
Wez
The CQ bit was checked by wez@chromium.org
6 years, 9 months ago (2014-03-05 21:30:19 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/28183002/260001
6 years, 9 months ago (2014-03-05 21:32:47 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 21:43:58 UTC) #19
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=275612
6 years, 9 months ago (2014-03-05 21:43:59 UTC) #20
Wez
The CQ bit was checked by wez@chromium.org
6 years, 9 months ago (2014-03-05 21:54:32 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/28183002/260001
6 years, 9 months ago (2014-03-05 21:56:13 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/28183002/260001
6 years, 9 months ago (2014-03-06 00:04:16 UTC) #23
commit-bot: I haz the power
Change committed as 255208
6 years, 9 months ago (2014-03-06 01:49:24 UTC) #24
Wez
The CQ bit was checked by wez@chromium.org
6 years, 9 months ago (2014-03-29 05:16:58 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/28183002/260001
6 years, 9 months ago (2014-03-29 05:17:12 UTC) #26
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-29 06:50:34 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 9 months ago (2014-03-29 06:50:34 UTC) #28
Wez
The CQ bit was checked by wez@chromium.org
6 years, 8 months ago (2014-03-31 17:57:52 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/28183002/260001
6 years, 8 months ago (2014-03-31 17:59:20 UTC) #30
commit-bot: I haz the power
6 years, 8 months ago (2014-03-31 19:54:21 UTC) #31
Message was sent while issue was closed. 
Change committed as 260618

Powered by Google App Engine
This is Rietveld 408576698