runtime/vm/constant_propagator.cc - Issue 2818273002: Remove parent_level field of function type parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/constant_propagator.cc

Issue 2818273002: Remove parent_level field of function type parameters. (Closed)

Patch Set: address comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/constant_propagator.cc

diff --git a/runtime/vm/constant_propagator.cc b/runtime/vm/constant_propagator.cc

index a1279ec5d69447758975a1a1bcfce403918b5185..050c0ba2a99606affbf530fab27dbd375b478f8f 100644

--- a/runtime/vm/constant_propagator.cc

+++ b/runtime/vm/constant_propagator.cc

@@ -764,8 +764,7 @@ void ConstantPropagator::VisitInstanceOf(InstanceOfInstr* instr) {

const Instance& instance = Instance::Cast(value);

const AbstractType& checked_type = instr->type();

if (instr->instantiator_type_arguments()->BindsToConstantNull() &&

- instr->function_type_arguments()->BindsToConstantNull() &&

- checked_type.IsInstantiated(kParentFunctions)) {

+ instr->function_type_arguments()->BindsToConstantNull()) {

Error& bound_error = Error::Handle();

bool is_instance =

instance.IsInstanceOf(checked_type, Object::null_type_arguments(),

« no previous file with comments | « runtime/vm/code_generator.cc ('k') | runtime/vm/flow_graph_builder.h » ('j') | no next file with comments »