Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1619)

Unified Diff: runtime/vm/intermediate_language_mips.cc

Issue 281823002: Fix an undetected Smi overflow on ARM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_mips.cc
===================================================================
--- runtime/vm/intermediate_language_mips.cc (revision 36182)
+++ runtime/vm/intermediate_language_mips.cc (working copy)
@@ -2675,24 +2675,24 @@
if (locs()->in(1).IsConstant()) {
const Object& constant = locs()->in(1).constant();
ASSERT(constant.IsSmi());
- int32_t imm = reinterpret_cast<int32_t>(constant.raw());
+ const int32_t imm = reinterpret_cast<int32_t>(constant.raw());
switch (op_kind()) {
- case Token::kSUB: {
- __ TraceSimMsg("kSUB imm");
+ case Token::kADD: {
if (deopt == NULL) {
- __ AddImmediate(result, left, -imm);
+ __ AddImmediate(result, left, imm);
} else {
- __ SubImmediateDetectOverflow(result, left, imm, CMPRES1);
+ Register temp = locs()->temp(0).reg();
+ __ AddImmediateDetectOverflow(result, left, imm, CMPRES1, temp);
__ bltz(CMPRES1, deopt);
}
break;
}
- case Token::kADD: {
+ case Token::kSUB: {
+ __ TraceSimMsg("kSUB imm");
if (deopt == NULL) {
- __ AddImmediate(result, left, imm);
+ __ AddImmediate(result, left, -imm);
} else {
- Register temp = locs()->temp(0).reg();
- __ AddImmediateDetectOverflow(result, left, imm, CMPRES1, temp);
+ __ SubImmediateDetectOverflow(result, left, imm, CMPRES1);
__ bltz(CMPRES1, deopt);
}
break;
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698