Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Side by Side Diff: runtime/vm/assembler_x64.h

Issue 281823002: Fix an undetected Smi overflow on ARM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/assembler_ia32.cc ('k') | runtime/vm/assembler_x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_ASSEMBLER_X64_H_ 5 #ifndef VM_ASSEMBLER_X64_H_
6 #define VM_ASSEMBLER_X64_H_ 6 #define VM_ASSEMBLER_X64_H_
7 7
8 #ifndef VM_ASSEMBLER_H_ 8 #ifndef VM_ASSEMBLER_H_
9 #error Do not include assembler_x64.h directly; use assembler.h instead. 9 #error Do not include assembler_x64.h directly; use assembler.h instead.
10 #endif 10 #endif
(...skipping 653 matching lines...) Expand 10 before | Expand all | Expand 10 after
664 // Issues a move instruction if 'to' is not the same as 'from'. 664 // Issues a move instruction if 'to' is not the same as 'from'.
665 void MoveRegister(Register to, Register from); 665 void MoveRegister(Register to, Register from);
666 void PopRegister(Register r); 666 void PopRegister(Register r);
667 667
668 // Macros accepting a pp Register argument may attempt to load values from 668 // Macros accepting a pp Register argument may attempt to load values from
669 // the object pool when possible. Unless you are sure that the untagged object 669 // the object pool when possible. Unless you are sure that the untagged object
670 // pool pointer is in another register, or that it is not available at all, 670 // pool pointer is in another register, or that it is not available at all,
671 // PP should be passed for pp. 671 // PP should be passed for pp.
672 void AddImmediate(Register reg, const Immediate& imm, Register pp); 672 void AddImmediate(Register reg, const Immediate& imm, Register pp);
673 void AddImmediate(const Address& address, const Immediate& imm, Register pp); 673 void AddImmediate(const Address& address, const Immediate& imm, Register pp);
674 void SubImmediate(Register reg, const Immediate& imm, Register pp);
675 void SubImmediate(const Address& address, const Immediate& imm, Register pp);
674 676
675 void Drop(intptr_t stack_elements); 677 void Drop(intptr_t stack_elements);
676 678
677 enum Patchability { 679 enum Patchability {
678 kPatchable, 680 kPatchable,
679 kNotPatchable, 681 kNotPatchable,
680 }; 682 };
681 683
682 bool CanLoadImmediateFromPool(const Immediate& imm, Register pp); 684 bool CanLoadImmediateFromPool(const Immediate& imm, Register pp);
683 void LoadImmediate(Register reg, const Immediate& imm, Register pp); 685 void LoadImmediate(Register reg, const Immediate& imm, Register pp);
(...skipping 379 matching lines...) Expand 10 before | Expand all | Expand 10 after
1063 } 1065 }
1064 1066
1065 1067
1066 inline void Assembler::EmitOperandSizeOverride() { 1068 inline void Assembler::EmitOperandSizeOverride() {
1067 EmitUint8(0x66); 1069 EmitUint8(0x66);
1068 } 1070 }
1069 1071
1070 } // namespace dart 1072 } // namespace dart
1071 1073
1072 #endif // VM_ASSEMBLER_X64_H_ 1074 #endif // VM_ASSEMBLER_X64_H_
OLDNEW
« no previous file with comments | « runtime/vm/assembler_ia32.cc ('k') | runtime/vm/assembler_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698