Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(982)

Side by Side Diff: runtime/vm/assembler_ia32.h

Issue 281823002: Fix an undetected Smi overflow on ARM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/assembler_arm64.cc ('k') | runtime/vm/assembler_ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_ASSEMBLER_IA32_H_ 5 #ifndef VM_ASSEMBLER_IA32_H_
6 #define VM_ASSEMBLER_IA32_H_ 6 #define VM_ASSEMBLER_IA32_H_
7 7
8 #ifndef VM_ASSEMBLER_H_ 8 #ifndef VM_ASSEMBLER_H_
9 #error Do not include assembler_ia32.h directly; use assembler.h instead. 9 #error Do not include assembler_ia32.h directly; use assembler.h instead.
10 #endif 10 #endif
(...skipping 609 matching lines...) Expand 10 before | Expand all | Expand 10 after
620 * Macros for High-level operations and implemented on all architectures. 620 * Macros for High-level operations and implemented on all architectures.
621 */ 621 */
622 622
623 void CompareRegisters(Register a, Register b); 623 void CompareRegisters(Register a, Register b);
624 624
625 // Issues a move instruction if 'to' is not the same as 'from'. 625 // Issues a move instruction if 'to' is not the same as 'from'.
626 void MoveRegister(Register to, Register from); 626 void MoveRegister(Register to, Register from);
627 void PopRegister(Register r); 627 void PopRegister(Register r);
628 628
629 void AddImmediate(Register reg, const Immediate& imm); 629 void AddImmediate(Register reg, const Immediate& imm);
630 void SubImmediate(Register reg, const Immediate& imm);
630 631
631 void Drop(intptr_t stack_elements); 632 void Drop(intptr_t stack_elements);
632 633
633 void LoadObject(Register dst, const Object& object); 634 void LoadObject(Register dst, const Object& object);
634 635
635 // If 'object' is a large Smi, xor it with a per-assembler cookie value to 636 // If 'object' is a large Smi, xor it with a per-assembler cookie value to
636 // prevent user-controlled immediates from appearing in the code stream. 637 // prevent user-controlled immediates from appearing in the code stream.
637 void LoadObjectSafely(Register dst, const Object& object); 638 void LoadObjectSafely(Register dst, const Object& object);
638 639
639 void PushObject(const Object& object); 640 void PushObject(const Object& object);
(...skipping 252 matching lines...) Expand 10 before | Expand all | Expand 10 after
892 } 893 }
893 894
894 895
895 inline void Assembler::EmitOperandSizeOverride() { 896 inline void Assembler::EmitOperandSizeOverride() {
896 EmitUint8(0x66); 897 EmitUint8(0x66);
897 } 898 }
898 899
899 } // namespace dart 900 } // namespace dart
900 901
901 #endif // VM_ASSEMBLER_IA32_H_ 902 #endif // VM_ASSEMBLER_IA32_H_
OLDNEW
« no previous file with comments | « runtime/vm/assembler_arm64.cc ('k') | runtime/vm/assembler_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698