Issue 28181: A fix for Issue 4400 (or maybe 4222)....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 28181: A fix for Issue 4400 (or maybe 4222).... (Closed)

Created:
11 years, 10 months ago by Hironori Bono

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

A fix for Issue 4400 (or maybe 4222). Sorry for my slow change. I noticed we should use the DLU size to calculate the expected text width only when it is smaller than average character width, i.e. ave_char_width(). (The DLU size becomes smaller than the average character width only when a font contains lots of CJK characters because most of CJK characters are much wider than alphabets.) So, this change uses the DLU size only when it is smaller than the average character width. I wish this makes you happy. Also, this change replaces TAB characters with spaces. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10586

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/common/gfx/chrome_font_win.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages