Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: ios/chrome/browser/payments/shipping_option_selection_view_controller.mm

Issue 2817953002: CollectionViewTextItem no longer styles CollectionViewTextCell (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/payments/shipping_option_selection_view_controller.mm
diff --git a/ios/chrome/browser/payments/shipping_option_selection_view_controller.mm b/ios/chrome/browser/payments/shipping_option_selection_view_controller.mm
index 303212d286cbd20bf4314fbbf888840476ee13dc..d165e772ce7a40a8becc4462f4da18e05fb8d86e 100644
--- a/ios/chrome/browser/payments/shipping_option_selection_view_controller.mm
+++ b/ios/chrome/browser/payments/shipping_option_selection_view_controller.mm
@@ -16,6 +16,7 @@
#import "ios/chrome/browser/ui/autofill/cells/status_item.h"
#import "ios/chrome/browser/ui/collection_view/cells/MDCCollectionViewCell+Chrome.h"
#import "ios/chrome/browser/ui/collection_view/cells/collection_view_item.h"
+#import "ios/chrome/browser/ui/collection_view/cells/collection_view_text_cell.h"
#import "ios/chrome/browser/ui/collection_view/cells/collection_view_text_item.h"
#import "ios/chrome/browser/ui/collection_view/collection_view_model.h"
#import "ios/chrome/browser/ui/colors/MDCPalette+CrAdditions.h"
@@ -128,12 +129,6 @@ typedef NS_ENUM(NSInteger, ItemType) {
item.detailText = SysUTF16ToNSString(currencyFormatter->Format(
base::UTF16ToASCII(shippingOption->amount.value)));
- // Styling.
- item.textFont = [MDCTypography body2Font];
- item.textColor = [[MDCPalette greyPalette] tint900];
- item.detailTextFont = [MDCTypography body1Font];
- item.detailTextColor = [[MDCPalette greyPalette] tint900];
-
if (_paymentRequest->selected_shipping_option() == shippingOption) {
item.accessoryType = MDCCollectionViewCellAccessoryCheckmark;
_selectedItem = item;
@@ -165,6 +160,12 @@ typedef NS_ENUM(NSInteger, ItemType) {
NSInteger itemType =
[self.collectionViewModel itemTypeForIndexPath:indexPath];
switch (itemType) {
+ case ItemTypeShippingOption: {
+ CollectionViewTextCell* textCell =
+ base::mac::ObjCCastStrict<CollectionViewTextCell>(cell);
+ textCell.detailTextLabel.textColor = [[MDCPalette greyPalette] tint900];
+ break;
+ }
case ItemTypeMessage: {
PaymentsTextCell* messageCell =
base::mac::ObjCCastStrict<PaymentsTextCell>(cell);

Powered by Google App Engine
This is Rietveld 408576698