ios/chrome/browser/ui/settings/translate_collection_view_controller.mm - Issue 2817953002: CollectionViewTextItem no longer styles CollectionViewTextCell

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/settings/translate_collection_view_controller.mm

Issue 2817953002: CollectionViewTextItem no longer styles CollectionViewTextCell (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ios/chrome/browser/ui/collection_view/cells/collection_view_text_item.mm ('K') | « ios/chrome/browser/ui/settings/time_range_selector_collection_view_controller.mm ('k') | ios/chrome/browser/ui/settings/voicesearch_collection_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/settings/translate_collection_view_controller.mm

diff --git a/ios/chrome/browser/ui/settings/translate_collection_view_controller.mm b/ios/chrome/browser/ui/settings/translate_collection_view_controller.mm

index ef4a29c9c4c7e60db95ce4a0c50e0f57f25d5efc..d0694f5d2553bd69ed852d7e4c79f65a60729790 100644

--- a/ios/chrome/browser/ui/settings/translate_collection_view_controller.mm

+++ b/ios/chrome/browser/ui/settings/translate_collection_view_controller.mm

@@ -19,6 +19,7 @@

#import "ios/chrome/browser/ui/collection_view/cells/MDCCollectionViewCell+Chrome.h"

#import "ios/chrome/browser/ui/collection_view/cells/collection_view_footer_item.h"

#import "ios/chrome/browser/ui/collection_view/cells/collection_view_switch_item.h"

+#import "ios/chrome/browser/ui/collection_view/cells/collection_view_text_cell.h"

#import "ios/chrome/browser/ui/collection_view/cells/collection_view_text_item.h"

#import "ios/chrome/browser/ui/collection_view/collection_view_model.h"

#import "ios/chrome/browser/ui/settings/settings_utils.h"

@@ -107,7 +108,6 @@ NSString* const kTranslateSettingsCategory = @"ChromeTranslateSettings";

initWithType:ItemTypeResetTranslate] autorelease];

resetTranslate.text = l10n_util::GetNSString(IDS_IOS_TRANSLATE_SETTING_RESET);

resetTranslate.accessibilityTraits |= UIAccessibilityTraitButton;

- resetTranslate.textFont = [MDCTypography body2Font];

[model addItem:resetTranslate

toSectionWithIdentifier:SectionIdentifierTranslate];

@@ -141,6 +141,15 @@ NSString* const kTranslateSettingsCategory = @"ChromeTranslateSettings";

forControlEvents:UIControlEventValueChanged];

break;

}

+ case ItemTypeResetTranslate: {

+ CollectionViewTextCell* textCell =

+ base::mac::ObjCCastStrict<CollectionViewTextCell>(cell);

+ textCell.textLabel.font = [MDCTypography body2Font];

+ textCell.textLabel.textColor = [[MDCPalette greyPalette] tint900];

+ textCell.detailTextLabel.font = [MDCTypography body1Font];

+ textCell.detailTextLabel.textColor = [[MDCPalette greyPalette] tint500];

+ break;

+ }

default:

break;

}