Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Side by Side Diff: ios/chrome/browser/ui/settings/settings_collection_view_controller.mm

Issue 2817953002: CollectionViewTextItem no longer styles CollectionViewTextCell (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/chrome/browser/ui/settings/settings_collection_view_controller.h" 5 #import "ios/chrome/browser/ui/settings/settings_collection_view_controller.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #import "base/ios/weak_nsobject.h" 9 #import "base/ios/weak_nsobject.h"
10 #import "base/mac/foundation_util.h" 10 #import "base/mac/foundation_util.h"
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 #import "ios/chrome/browser/ui/authentication/signin_interaction_controller.h" 42 #import "ios/chrome/browser/ui/authentication/signin_interaction_controller.h"
43 #import "ios/chrome/browser/ui/authentication/signin_promo_item.h" 43 #import "ios/chrome/browser/ui/authentication/signin_promo_item.h"
44 #import "ios/chrome/browser/ui/authentication/signin_promo_view.h" 44 #import "ios/chrome/browser/ui/authentication/signin_promo_view.h"
45 #import "ios/chrome/browser/ui/authentication/signin_promo_view_configurator.h" 45 #import "ios/chrome/browser/ui/authentication/signin_promo_view_configurator.h"
46 #import "ios/chrome/browser/ui/authentication/signin_promo_view_consumer.h" 46 #import "ios/chrome/browser/ui/authentication/signin_promo_view_consumer.h"
47 #import "ios/chrome/browser/ui/authentication/signin_promo_view_mediator.h" 47 #import "ios/chrome/browser/ui/authentication/signin_promo_view_mediator.h"
48 #import "ios/chrome/browser/ui/collection_view/cells/MDCCollectionViewCell+Chrom e.h" 48 #import "ios/chrome/browser/ui/collection_view/cells/MDCCollectionViewCell+Chrom e.h"
49 #import "ios/chrome/browser/ui/collection_view/cells/collection_view_account_ite m.h" 49 #import "ios/chrome/browser/ui/collection_view/cells/collection_view_account_ite m.h"
50 #import "ios/chrome/browser/ui/collection_view/cells/collection_view_detail_item .h" 50 #import "ios/chrome/browser/ui/collection_view/cells/collection_view_detail_item .h"
51 #import "ios/chrome/browser/ui/collection_view/cells/collection_view_switch_item .h" 51 #import "ios/chrome/browser/ui/collection_view/cells/collection_view_switch_item .h"
52 #import "ios/chrome/browser/ui/collection_view/cells/collection_view_text_cell.h "
52 #import "ios/chrome/browser/ui/collection_view/cells/collection_view_text_item.h " 53 #import "ios/chrome/browser/ui/collection_view/cells/collection_view_text_item.h "
53 #import "ios/chrome/browser/ui/collection_view/collection_view_model.h" 54 #import "ios/chrome/browser/ui/collection_view/collection_view_model.h"
54 #import "ios/chrome/browser/ui/colors/MDCPalette+CrAdditions.h" 55 #import "ios/chrome/browser/ui/colors/MDCPalette+CrAdditions.h"
55 #import "ios/chrome/browser/ui/settings/about_chrome_collection_view_controller. h" 56 #import "ios/chrome/browser/ui/settings/about_chrome_collection_view_controller. h"
56 #import "ios/chrome/browser/ui/settings/accounts_collection_view_controller.h" 57 #import "ios/chrome/browser/ui/settings/accounts_collection_view_controller.h"
57 #import "ios/chrome/browser/ui/settings/autofill_collection_view_controller.h" 58 #import "ios/chrome/browser/ui/settings/autofill_collection_view_controller.h"
58 #import "ios/chrome/browser/ui/settings/bandwidth_management_collection_view_con troller.h" 59 #import "ios/chrome/browser/ui/settings/bandwidth_management_collection_view_con troller.h"
59 #import "ios/chrome/browser/ui/settings/cells/account_signin_item.h" 60 #import "ios/chrome/browser/ui/settings/cells/account_signin_item.h"
60 #import "ios/chrome/browser/ui/settings/content_settings_collection_view_control ler.h" 61 #import "ios/chrome/browser/ui/settings/content_settings_collection_view_control ler.h"
61 #import "ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.h" 62 #import "ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.h"
62 #import "ios/chrome/browser/ui/settings/native_apps_collection_view_controller.h " 63 #import "ios/chrome/browser/ui/settings/native_apps_collection_view_controller.h "
63 #import "ios/chrome/browser/ui/settings/privacy_collection_view_controller.h" 64 #import "ios/chrome/browser/ui/settings/privacy_collection_view_controller.h"
64 #import "ios/chrome/browser/ui/settings/save_passwords_collection_view_controlle r.h" 65 #import "ios/chrome/browser/ui/settings/save_passwords_collection_view_controlle r.h"
65 #import "ios/chrome/browser/ui/settings/search_engine_settings_collection_view_c ontroller.h" 66 #import "ios/chrome/browser/ui/settings/search_engine_settings_collection_view_c ontroller.h"
66 #import "ios/chrome/browser/ui/settings/settings_utils.h" 67 #import "ios/chrome/browser/ui/settings/settings_utils.h"
67 #import "ios/chrome/browser/ui/settings/utils/pref_backed_boolean.h" 68 #import "ios/chrome/browser/ui/settings/utils/pref_backed_boolean.h"
68 #import "ios/chrome/browser/ui/settings/voicesearch_collection_view_controller.h " 69 #import "ios/chrome/browser/ui/settings/voicesearch_collection_view_controller.h "
69 #import "ios/chrome/browser/ui/sync/sync_util.h" 70 #import "ios/chrome/browser/ui/sync/sync_util.h"
70 #import "ios/chrome/browser/ui/uikit_ui_util.h" 71 #import "ios/chrome/browser/ui/uikit_ui_util.h"
71 #include "ios/chrome/browser/voice/speech_input_locale_config.h" 72 #include "ios/chrome/browser/voice/speech_input_locale_config.h"
72 #include "ios/chrome/grit/ios_chromium_strings.h" 73 #include "ios/chrome/grit/ios_chromium_strings.h"
73 #include "ios/chrome/grit/ios_strings.h" 74 #include "ios/chrome/grit/ios_strings.h"
74 #import "ios/public/provider/chrome/browser/chrome_browser_provider.h" 75 #import "ios/public/provider/chrome/browser/chrome_browser_provider.h"
75 #import "ios/public/provider/chrome/browser/signin/chrome_identity.h" 76 #import "ios/public/provider/chrome/browser/signin/chrome_identity.h"
76 #import "ios/public/provider/chrome/browser/signin/signin_resources_provider.h" 77 #import "ios/public/provider/chrome/browser/signin/signin_resources_provider.h"
77 #include "ios/public/provider/chrome/browser/voice/voice_search_prefs.h" 78 #include "ios/public/provider/chrome/browser/voice/voice_search_prefs.h"
79 #import "ios/third_party/material_components_ios/src/components/Typography/src/M aterialTypography.h"
78 #include "ui/base/l10n/l10n_util_mac.h" 80 #include "ui/base/l10n/l10n_util_mac.h"
79 81
80 NSString* const kSettingsCollectionViewId = @"kSettingsCollectionViewId"; 82 NSString* const kSettingsCollectionViewId = @"kSettingsCollectionViewId";
81 NSString* const kSettingsSignInCellId = @"kSettingsSignInCellId"; 83 NSString* const kSettingsSignInCellId = @"kSettingsSignInCellId";
82 NSString* const kSettingsAccountCellId = @"kSettingsAccountCellId"; 84 NSString* const kSettingsAccountCellId = @"kSettingsAccountCellId";
83 NSString* const kSettingsSearchEngineCellId = @"Search Engine"; 85 NSString* const kSettingsSearchEngineCellId = @"Search Engine";
84 NSString* const kSettingsVoiceSearchCellId = @"Voice Search Settings"; 86 NSString* const kSettingsVoiceSearchCellId = @"Voice Search Settings";
85 87
86 @interface SettingsCollectionViewController (NotificationBridgeDelegate) 88 @interface SettingsCollectionViewController (NotificationBridgeDelegate)
87 // Notifies this controller that the sign in state has changed. 89 // Notifies this controller that the sign in state has changed.
(...skipping 254 matching lines...) Expand 10 before | Expand all | Expand 10 after
342 _signinPromoViewMediator.reset(nil); 344 _signinPromoViewMediator.reset(nil);
343 [model addItem:[self accountCellItem] 345 [model addItem:[self accountCellItem]
344 toSectionWithIdentifier:SectionIdentifierSignIn]; 346 toSectionWithIdentifier:SectionIdentifierSignIn];
345 } 347 }
346 348
347 // Basics section 349 // Basics section
348 [model addSectionWithIdentifier:SectionIdentifierBasics]; 350 [model addSectionWithIdentifier:SectionIdentifierBasics];
349 CollectionViewTextItem* basicsHeader = [ 351 CollectionViewTextItem* basicsHeader = [
350 [[CollectionViewTextItem alloc] initWithType:ItemTypeHeader] autorelease]; 352 [[CollectionViewTextItem alloc] initWithType:ItemTypeHeader] autorelease];
351 basicsHeader.text = l10n_util::GetNSString(IDS_IOS_OPTIONS_GENERAL_TAB_LABEL); 353 basicsHeader.text = l10n_util::GetNSString(IDS_IOS_OPTIONS_GENERAL_TAB_LABEL);
352 basicsHeader.textColor = [[MDCPalette greyPalette] tint500];
353 [model setHeader:basicsHeader 354 [model setHeader:basicsHeader
354 forSectionWithIdentifier:SectionIdentifierBasics]; 355 forSectionWithIdentifier:SectionIdentifierBasics];
355 [model addItem:[self searchEngineDetailItem] 356 [model addItem:[self searchEngineDetailItem]
356 toSectionWithIdentifier:SectionIdentifierBasics]; 357 toSectionWithIdentifier:SectionIdentifierBasics];
357 [model addItem:[self savePasswordsDetailItem] 358 [model addItem:[self savePasswordsDetailItem]
358 toSectionWithIdentifier:SectionIdentifierBasics]; 359 toSectionWithIdentifier:SectionIdentifierBasics];
359 [model addItem:[self autoFillDetailItem] 360 [model addItem:[self autoFillDetailItem]
360 toSectionWithIdentifier:SectionIdentifierBasics]; 361 toSectionWithIdentifier:SectionIdentifierBasics];
361 [model addItem:[self nativeAppsDetailItem] 362 [model addItem:[self nativeAppsDetailItem]
362 toSectionWithIdentifier:SectionIdentifierBasics]; 363 toSectionWithIdentifier:SectionIdentifierBasics];
363 364
364 // Advanced Section 365 // Advanced Section
365 [model addSectionWithIdentifier:SectionIdentifierAdvanced]; 366 [model addSectionWithIdentifier:SectionIdentifierAdvanced];
366 CollectionViewTextItem* advancedHeader = [ 367 CollectionViewTextItem* advancedHeader = [
367 [[CollectionViewTextItem alloc] initWithType:ItemTypeHeader] autorelease]; 368 [[CollectionViewTextItem alloc] initWithType:ItemTypeHeader] autorelease];
368 advancedHeader.text = 369 advancedHeader.text =
369 l10n_util::GetNSString(IDS_IOS_OPTIONS_ADVANCED_TAB_LABEL); 370 l10n_util::GetNSString(IDS_IOS_OPTIONS_ADVANCED_TAB_LABEL);
370 advancedHeader.textColor = [[MDCPalette greyPalette] tint500];
371 [model setHeader:advancedHeader 371 [model setHeader:advancedHeader
372 forSectionWithIdentifier:SectionIdentifierAdvanced]; 372 forSectionWithIdentifier:SectionIdentifierAdvanced];
373 [model addItem:[self voiceSearchDetailItem] 373 [model addItem:[self voiceSearchDetailItem]
374 toSectionWithIdentifier:SectionIdentifierAdvanced]; 374 toSectionWithIdentifier:SectionIdentifierAdvanced];
375 [model addItem:[self privacyDetailItem] 375 [model addItem:[self privacyDetailItem]
376 toSectionWithIdentifier:SectionIdentifierAdvanced]; 376 toSectionWithIdentifier:SectionIdentifierAdvanced];
377 [model addItem:[self contentSettingsDetailItem] 377 [model addItem:[self contentSettingsDetailItem]
378 toSectionWithIdentifier:SectionIdentifierAdvanced]; 378 toSectionWithIdentifier:SectionIdentifierAdvanced];
379 [model addItem:[self bandwidthManagementDetailItem] 379 [model addItem:[self bandwidthManagementDetailItem]
380 toSectionWithIdentifier:SectionIdentifierAdvanced]; 380 toSectionWithIdentifier:SectionIdentifierAdvanced];
381 381
382 // Info Section 382 // Info Section
383 [model addSectionWithIdentifier:SectionIdentifierInfo]; 383 [model addSectionWithIdentifier:SectionIdentifierInfo];
384 [model addItem:[self aboutChromeDetailItem] 384 [model addItem:[self aboutChromeDetailItem]
385 toSectionWithIdentifier:SectionIdentifierInfo]; 385 toSectionWithIdentifier:SectionIdentifierInfo];
386 386
387 // Debug Section 387 // Debug Section
388 if ([self hasDebugSection]) { 388 if ([self hasDebugSection]) {
389 [model addSectionWithIdentifier:SectionIdentifierDebug]; 389 [model addSectionWithIdentifier:SectionIdentifierDebug];
390 CollectionViewTextItem* debugHeader = [[[CollectionViewTextItem alloc] 390 CollectionViewTextItem* debugHeader = [[[CollectionViewTextItem alloc]
391 initWithType:ItemTypeHeader] autorelease]; 391 initWithType:ItemTypeHeader] autorelease];
392 debugHeader.text = @"Debug"; 392 debugHeader.text = @"Debug";
393 debugHeader.textColor = [[MDCPalette greyPalette] tint500];
394 [model setHeader:debugHeader 393 [model setHeader:debugHeader
395 forSectionWithIdentifier:SectionIdentifierDebug]; 394 forSectionWithIdentifier:SectionIdentifierDebug];
396 } 395 }
397 396
398 if (experimental_flags::IsMemoryDebuggingEnabled()) { 397 if (experimental_flags::IsMemoryDebuggingEnabled()) {
399 _showMemoryDebugToolsItem.reset([[self showMemoryDebugSwitchItem] retain]); 398 _showMemoryDebugToolsItem.reset([[self showMemoryDebugSwitchItem] retain]);
400 [model addItem:_showMemoryDebugToolsItem 399 [model addItem:_showMemoryDebugToolsItem
401 toSectionWithIdentifier:SectionIdentifierDebug]; 400 toSectionWithIdentifier:SectionIdentifierDebug];
402 } 401 }
403 402
(...skipping 246 matching lines...) Expand 10 before | Expand all | Expand 10 after
650 [[MDCPalette greyPalette] tint400]; 649 [[MDCPalette greyPalette] tint400];
651 } 650 }
652 } else { 651 } else {
653 [detailCell setUserInteractionEnabled:YES]; 652 [detailCell setUserInteractionEnabled:YES];
654 detailCell.textLabel.textColor = [[MDCPalette greyPalette] tint900]; 653 detailCell.textLabel.textColor = [[MDCPalette greyPalette] tint900];
655 detailCell.detailTextLabel.textColor = [[MDCPalette greyPalette] tint500]; 654 detailCell.detailTextLabel.textColor = [[MDCPalette greyPalette] tint500];
656 } 655 }
657 } 656 }
658 657
659 switch (itemType) { 658 switch (itemType) {
659 case ItemTypeHeader: {
660 CollectionViewTextCell* textCell =
661 base::mac::ObjCCastStrict<CollectionViewTextCell>(cell);
662 textCell.textLabel.textColor = [[MDCPalette greyPalette] tint500];
663 break;
664 }
660 case ItemTypeMemoryDebugging: { 665 case ItemTypeMemoryDebugging: {
661 CollectionViewSwitchCell* switchCell = 666 CollectionViewSwitchCell* switchCell =
662 base::mac::ObjCCastStrict<CollectionViewSwitchCell>(cell); 667 base::mac::ObjCCastStrict<CollectionViewSwitchCell>(cell);
663 [switchCell.switchView addTarget:self 668 [switchCell.switchView addTarget:self
664 action:@selector(memorySwitchToggled:) 669 action:@selector(memorySwitchToggled:)
665 forControlEvents:UIControlEventValueChanged]; 670 forControlEvents:UIControlEventValueChanged];
666 break; 671 break;
667 } 672 }
668 case ItemTypeSigninPromo: { 673 case ItemTypeSigninPromo: {
669 SigninPromoCell* signinPromoCell = 674 SigninPromoCell* signinPromoCell =
(...skipping 488 matching lines...) Expand 10 before | Expand all | Expand 10 after
1158 if (signinPromoItem) { 1163 if (signinPromoItem) {
1159 signinPromoItem.configurator = configurator; 1164 signinPromoItem.configurator = configurator;
1160 [self reconfigureCellsForItems:@[ signinPromoItem ] 1165 [self reconfigureCellsForItems:@[ signinPromoItem ]
1161 inSectionWithIdentifier:SectionIdentifierSignIn]; 1166 inSectionWithIdentifier:SectionIdentifierSignIn];
1162 if (newIdentity) 1167 if (newIdentity)
1163 [self.collectionViewLayout invalidateLayout]; 1168 [self.collectionViewLayout invalidateLayout];
1164 } 1169 }
1165 } 1170 }
1166 1171
1167 @end 1172 @end
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698