CollectionViewTextItem no longer styles CollectionViewTextCell

ios/chrome/browser/ui/collection_view/cells/collection_view_text_item.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/collection_view/cells/collection_view_text_item.h"
 
 #import "ios/chrome/browser/ui/collection_view/cells/collection_view_text_cell.h"
-#import "ios/third_party/material_components_ios/src/components/Palettes/src/MaterialPalettes.h"
-#import "ios/third_party/material_roboto_font_loader_ios/src/src/MaterialRobotoFontLoader.h"
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)
 #error "This file requires ARC support."
 #endif
 
 @implementation CollectionViewTextItem
 
 @synthesize accessoryType = _accessoryType;
 @synthesize text = _text;
 @synthesize detailText = _detailText;
-@synthesize textFont = _textFont;
-@synthesize textColor = _textColor;
 @synthesize numberOfTextLines = _numberOfTextLines;
-@synthesize detailTextFont = _detailTextFont;
-@synthesize detailTextColor = _detailTextColor;
 @synthesize numberOfDetailTextLines = _numberOfDetailTextLines;
 
 - (instancetype)initWithType:(NSInteger)type {
   self = [super initWithType:type];
   if (self) {
     self.cellClass = [CollectionViewTextCell class];
     _numberOfTextLines = 1;
     _numberOfDetailTextLines = 1;
   }
   return self;
 }
 
-- (UIFont*)textFont {
-  if (!_textFont) {
-    _textFont = [[MDFRobotoFontLoader sharedInstance] mediumFontOfSize:14];

[lpromero, 2017/04/13 17:44:26]

Instead of moving these defaults in all the View Controllers, I would have moved
them to the CollectionViewTextCell. Then VCs can override when needed.

[Moe, 2017/04/13 18:48:58]

If the VCs only override the properties, don't we risk inadvertently changing
the font/color in a lot of places if the defaults in the cell change for some
reason?
I think having no defaults in the cell should force the author of the VC to
fully style it when using it and guard again those changes. wdyt?

[Moe, 2017/04/13 19:33:38]

Done.

[lpromero, 2017/04/13 20:24:55]

It's sort of the point of having the default be like a "style". If specs change,
we change only in one place. But since on the other end, we sometimes override
these values, we are neither fully explicit nor DRY :(

-  }
-  return _textFont;
-}
-
-- (UIColor*)textColor {
-  if (!_textColor) {
-    _textColor = [[MDCPalette greyPalette] tint900];
-  }
-  return _textColor;
-}
-
-- (UIFont*)detailTextFont {
-  if (!_detailTextFont) {
-    _detailTextFont =
-        [[MDFRobotoFontLoader sharedInstance] regularFontOfSize:14];
-  }
-  return _detailTextFont;
-}
-
-- (UIColor*)detailTextColor {
-  if (!_detailTextColor) {
-    _detailTextColor = [[MDCPalette greyPalette] tint500];
-  }
-  return _detailTextColor;
-}
-
 #pragma mark CollectionViewItem
 
 - (void)configureCell:(CollectionViewTextCell*)cell {
   [super configureCell:cell];
   cell.accessoryType = self.accessoryType;
   cell.textLabel.text = self.text;
   cell.detailTextLabel.text = self.detailText;
   cell.isAccessibilityElement = YES;
   if (self.detailText.length == 0) {
     cell.accessibilityLabel = self.text;
   } else {
     cell.accessibilityLabel =
         [NSString stringWithFormat:@"%@, %@", self.text, self.detailText];
   }
 
   // Styling.
-  cell.textLabel.font = self.textFont;
-  cell.textLabel.textColor = self.textColor;
   cell.textLabel.numberOfLines = self.numberOfTextLines;
-  cell.detailTextLabel.font = self.detailTextFont;
-  cell.detailTextLabel.textColor = self.detailTextColor;
   cell.detailTextLabel.numberOfLines = self.numberOfDetailTextLines;
 }
 
 @end