ios/chrome/browser/ui/contextual_search/resources/contextualsearch.js - Issue 2817943002: Fully deprecate core.js. Moved last method to error.js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/contextual_search/resources/contextualsearch.js

Issue 2817943002: Fully deprecate core.js. Moved last method to error.js. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/chrome/browser/ui/contextual_search/resources/contextualsearch.js

diff --git a/ios/chrome/browser/ui/contextual_search/resources/contextualsearch.js b/ios/chrome/browser/ui/contextual_search/resources/contextualsearch.js

index ae36f5981389e757b8e605153df2e8512a34da73..2b93124a027a1078d0a74c492488dacbb955fb8e 100644

--- a/ios/chrome/browser/ui/contextual_search/resources/contextualsearch.js

+++ b/ios/chrome/browser/ui/contextual_search/resources/contextualsearch.js

@@ -786,7 +786,7 @@ Context.getContextDataFromPoint = function(x, y) {

* @private

Context.contextFromPoint = function(x, y) {

- // Should this use core.js's elementFromPoint_() instead?

+ // Should this use context_menu.js's elementFromPoint_() instead?

Eugene But (OOO till 7-30) 2017/04/13 16:30:06 Would you mind filing a bug and adding a TODO for

danyao 2017/04/13 17:40:45 Done.

var contextData = new ContextData();

var element = document.elementFromPoint(x, y);

if (!element) {

« no previous file with comments | « ios/chrome/browser/passwords/js_password_manager.h ('k') | ios/web/BUILD.gn » ('j') | ios/web/web_state/js/resources/error.js » ('J')