Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1548)

Unified Diff: chrome/browser/chromeos/login/existing_user_controller_browsertest.cc

Issue 2817933003: Wait for Cryptohome service to be available on login. (Closed)
Patch Set: better error handling + fix ExistingUserControllerActiveDirectoryTest Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
diff --git a/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc b/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
index 9566108f335e2168c4539d03ed31b47dfdbb643b..1698b17e8214fb556dfda8e8384439221e89ec02 100644
--- a/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
+++ b/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
@@ -784,6 +784,12 @@ class ExistingUserControllerActiveDirectoryTest
ExistingUserControllerTest::SetUpInProcessBrowserTestFixture();
}
+ // Overriden from ExistingUserControllerTest:
Roman Sorokin (ftl) 2017/04/18 14:30:18 nit: Remove the comment
+ void TearDownOnMainThread() override {
+ base::RunLoop().RunUntilIdle();
+ ExistingUserControllerTest::TearDownOnMainThread();
+ }
+
protected:
void ExpectLoginFailure() {
EXPECT_CALL(*mock_login_display_, SetUIEnabled(false)).Times(2);

Powered by Google App Engine
This is Rietveld 408576698