Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: chrome/browser/chromeos/login/existing_user_controller.h

Issue 2817933003: Wait for Cryptohome service to be available on login. (Closed)
Patch Set: better error handling + fix ExistingUserControllerActiveDirectoryTest Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/existing_user_controller.h
diff --git a/chrome/browser/chromeos/login/existing_user_controller.h b/chrome/browser/chromeos/login/existing_user_controller.h
index 32f8a497364c3e69c7bb2354b48da675ea897c42..f3a2ee72898555f2e15ee5769bdaf8f989da7436 100644
--- a/chrome/browser/chromeos/login/existing_user_controller.h
+++ b/chrome/browser/chromeos/login/existing_user_controller.h
@@ -251,6 +251,10 @@ class ExistingUserController
// auto-login timer is started.
void PerformLoginFinishedActions(bool start_auto_login_timer);
+ // Invokes |continuation| after verifying that cryptohome service is available
+ void ContinueLoginWhenCryptohomeAvailable(const base::Closure& continuation,
Roman Sorokin (ftl) 2017/04/18 13:30:42 Why not OnceClosure?
Sergey Poromov 2017/04/18 14:16:39 Because it's a callback from ContinueLoginIfDevice
Roman Sorokin (ftl) 2017/04/18 14:30:18 I guess passing it to PrepareTrustedValues is not
Sergey Poromov 2017/04/18 14:30:19 But on the other hand it could be left as (Repeate
+ bool service_is_available);
+
// Invokes |continuation| after verifying that the device is not disabled.
void ContinueLoginIfDeviceNotDisabled(const base::Closure& continuation);

Powered by Google App Engine
This is Rietveld 408576698