Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 281793002: Revert animation of Overview Button Tray (Closed)

Created:
6 years, 7 months ago by jonross
Modified:
6 years, 7 months ago
Reviewers:
flackr, oshima
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert animation of Overview Button Tray Initial change has a race condition that can cause the system tray and other items to become, and stay visible. Reverting to unblock dev. Revert "Animate the OverviewButtonTray" This reverts commit f2eb09cd51c6c3dec830abd6613c0df130b7c08f. Original review: https://codereview.chromium.org/251193004/ TBR=oshima@chromium.org BUG=372285 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270189

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -131 lines) Patch
M ash/system/status_area_widget_delegate.cc View 3 chunks +0 lines, -35 lines 0 comments Download
M ash/system/tray/tray_background_view.h View 6 chunks +7 lines, -17 lines 0 comments Download
M ash/system/tray/tray_background_view.cc View 6 chunks +2 lines, -79 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
jonross
Revert due to a race condition to unblock dev branch. Will develop a fix to ...
6 years, 7 months ago (2014-05-13 17:35:16 UTC) #1
jonross
6 years, 7 months ago (2014-05-13 17:36:25 UTC) #2
jonross
The CQ bit was checked by jonross@chromium.org
6 years, 7 months ago (2014-05-13 17:36:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jonross@chromium.org/281793002/1
6 years, 7 months ago (2014-05-13 17:37:48 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-13 17:37:50 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-13 17:37:50 UTC) #6
flackr
lgtm
6 years, 7 months ago (2014-05-13 17:59:31 UTC) #7
jonross
The CQ bit was checked by jonross@chromium.org
6 years, 7 months ago (2014-05-13 17:59:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jonross@chromium.org/281793002/1
6 years, 7 months ago (2014-05-13 18:00:29 UTC) #9
commit-bot: I haz the power
Change committed as 270189
6 years, 7 months ago (2014-05-13 20:31:39 UTC) #10
oshima
6 years, 7 months ago (2014-05-14 00:43:14 UTC) #11
Message was sent while issue was closed.
On 2014/05/13 20:31:39, I haz the power (commit-bot) wrote:
> Change committed as 270189

tip: drover --revert 269378
is easier (at least for me)

Powered by Google App Engine
This is Rietveld 408576698