Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 28179: Now we sort encoding menu according to current application locale, we also... (Closed)

Created:
11 years, 10 months ago by Johnny(Jianning) Ding
Modified:
9 years, 7 months ago
Reviewers:
jungshik at Google
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Now we sort encoding menu according to current application locale, we also need to sort the "Default Encoding" drop down list under "Chrome Options->Minor Tweaks->Fonts and Encoding" since Firefox already supports it. BUG=8084 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10583

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -4 lines) Patch
M chrome/browser/character_encoding.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/character_encoding.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/views/options/fonts_page_view.cc View 1 4 chunks +22 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Johnny(Jianning) Ding
11 years, 10 months ago (2009-02-26 08:58:35 UTC) #1
jungshik at Google
lgtm with one minor nit.
11 years, 10 months ago (2009-02-26 20:07:13 UTC) #2
jungshik at Google
lgtm with one minor nit addressed. http://codereview.chromium.org/28179/diff/1/3 File chrome/browser/views/options/fonts_page_view.cc (right): http://codereview.chromium.org/28179/diff/1/3#newcode40 Line 40: static std::vector<CharacterEncoding::EncodingInfo> ...
11 years, 10 months ago (2009-02-26 20:07:45 UTC) #3
Johnny(Jianning) Ding
11 years, 10 months ago (2009-02-27 04:20:58 UTC) #4
http://codereview.chromium.org/28179/diff/1/3
File chrome/browser/views/options/fonts_page_view.cc (right):

http://codereview.chromium.org/28179/diff/1/3#newcode40
Line 40: static std::vector<CharacterEncoding::EncodingInfo>
all_sorted_encodings_;
On 2009/02/26 20:07:45, Jungshik Shin wrote:
> nit: sorted_encoding_list_ seems to be a better name.

Done.

Powered by Google App Engine
This is Rietveld 408576698